[request-tracker-maintainers] RT 5.0

[Dominic Hargreaves]

On Wed, Jul 01, 2020 at 10:53:23AM +1200, Andrew Ruthven wrote:
> On Tue, 2020-06-30 at 22:04 +0100, Dominic Hargreaves wrote:

> > 
> > https://salsa.debian.org/request-tracker-team/rt-extension-elapsedbusinesshours
> > 
> > is not yet populated.
> 
> Oops, pushed now.
> 
> I believe they're ready. The only thing is the debian/changelog file
> for most of them have previous versions in them as I've been deploying
> them internally. We may need to merge them down.

I don't think merging the changelogs is necessary - sometimes the
context for prior development can be helpful. It's necessary to supply
-v to dpkg-buildpackage in such a case. But if we're making other changes
too, I agree it's worth considering. Equally you could bump the initial
upload to Debian to -2 (as long as we include -sa).

I had a look at these packages, and I have some general feedback as
well as specific ones.

General
- please switch to source format 3 so it's easier to add packages in the
  future if needed
- please switch to team maintenance
  Maintainer: Debian Request Tracker Group <pkg-request-tracker-maintainers at lists.alioth.debian.org>

rt-extension-resetpassword

- upstream is from git, and the tree does not match the released tarball
  on CPAN. It looks like 1.06 hasn't actually been released? Certainly
  as far as RT and perl module packaging goes, we don't import the upstream
  git repo directly but use git-import-orig or equivalent. Please can
  you repackage using 1.05 (and/or if there are important things needed from
  git, add them as patches, perhaps using git-dpm, or
  persuade upstream to release 1.06).

rt-extension-rest2

- as above, upstream is from git and MANIFEST doesn't match

rt-extension-mergeusers

- as above, upstream is from git and MANIFEST doesn't match
- this is hidden by debian/source/format, but I don't believe this is an
  intended use of this option. Our source tree should match the upstream
  release tarballs in preference to upstream git.
- 1.06 is now available

rt-extension-commandbymail

- (as you pointed out it's already been uploaded - as librt-extension-commandbymail-perl)
- ah, and also has a non-standard (from our point of view) package
  naming, that's unfortunate. We should reach out, certainly at the
  point we're transitioning extensions to RT5, with an offer to bring it
  into team maintenance, but in the meantime, are you okay for me to
  remove rt-extension-commandbymail.git from the team salsa project, to
  avoid confusion?

rt-extension-assetautoname

- I see you've prepared this for use with RT5. I wonder if it might be
  a good opportunity to test building both rt4* and rt5* packages?
- otherwise looks basically, but there are some lintian errors/warnings
  to fix (possible-missing-colon-in-closes and
  missing-license-paragraph-in-dep5-copyright)

rt-extension-elapsedbusinesstime

- I renamed the path for this so it now appears at
  git at salsa.debian.org:request-tracker-team/rt-extension-elapsedbusinesstime.git
  (it turns out that renaming a project doesn't rename its path (!)
- rt-extension-elapsedbusinesstime/Changes is missing from the tarball but
  added in git.
  - maybe fixed in new upstream release?

Sorry again for the slow review. I'll try and do much better at
subsequent reviews - just ping me by email or IRC (Dom on OFTC) as and
when you make progress.

Cheers
Dominic