[Pkg-roundcube-maintainers] Bug#619411: roundcube-core: program/include/iniset.php should not alter INSTALL_PATH constant

[Teodor MICU]

2011/3/24 Vincent Bernat <bernat at debian.org>:
> OoO En  cette fin  de nuit blanche  du jeudi  24 mars 2011,  vers 06:19,
> Teodor MICU <mteodor at gmail.com> disait :
>> I'm using roundcube with the upstream 'iniset.php' with no problems.
>
> SCRIPT_FILENAME may be  set by a lot of components. It  is set by Apache
> if you use  mod_php, set by PHP if  you use FPM, etc. I did  not find an
> authoritative  source if  SCRIPT_FILENAME  should or  should not  follow
> symlinks. I don't remember why we  created this patch but I suppose this
> was a useful once.

Look, this is quite simple. Roundcube upstream is using it and Debian
has modified it to a hardcoded value that is not necessary. I've
proven that it works either way.

> Romain, did you remember why you put this patch?

That would be good to know, but the above point remains valid.

>> I've cloned '/var/lib/roundcube' (with rsync) on a different directory
>> in /var/www for a new virtual host designed only for mobile devices
>> (smart phones). Afterwards I just changed a few symbolic links
>> (config/main.inc.php, logs) and added a new skin. But for this to work
>> I had to change the iniset.php to detect automatically INSTALL_PATH.
>
> This is a very particular setup.  I would like not to break other setups
> by removing the patch.

I've proved that nothing gets broken. Also, the setup you put in place
in roundcube Debian packages is even suitable to support multiple
roundcube virtual hosts since all the content from
/usr/share/roundcube is linked in /var/lib/roundcube. If
/var/lib/roundcube did not exist at all the /roundcube was set to
/usr/share/roundcube than anyone who would like to setup a virtual
host will create a directory with what is now in /var/lib/roundcube.
It's just a flexible way to add/remove plugins, skins or set a custom
main.inc.php. The alternative is just a burden to maintain different
copies of roundcube.

Thanks