[Pkg-roundcube-maintainers] Bug#686857: [roundcube] uuencoded attachments not recognized

[Vincent Bernat]

 ❦  6 septembre 2012 20:08 CEST, Michał Mirosław <mirq-boogs at rere.qmqm.pl> :

> Package: roundcube
> Version: 0.7.1-1~bpo60+1, 0.7.2-4
> Severity: normal
> Tags: patch
>
> --- Please enter the report below this line. ---
>
> Roundcube 0.7 doesn't properly recognize uuencoded attachments. Patch below, for 0.7.1-1~bpo60+1 (same changes needed in 0.7.2-4 in 
> testing).
>
> --- /usr/share/roundcube/program/include/rcube_message.php.orig	2012-01-17 08:50:40.000000000 +0100
> +++ /usr/share/roundcube/program/include/rcube_message.php	2012-09-06 19:54:54.000000000 +0200
> @@ -622,8 +622,7 @@
>              $part->body = $this->imap->get_message_part($this->uid, $part->mime_id, $part);
>  
>          $parts = array();
> -        // FIXME: line length is max.65?
> -        $uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n(([\x21-\x7E]{0,65}\n)+)`\nend/s';
> +        $uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n(([\x20-\x60]{0,65}\n)+)`\nend/s';
>  
>          if (preg_match_all($uu_regexp, $part->body, $matches, PREG_SET_ORDER)) {
>              // remove attachments bodies from the message body

Hi!

Thanks for the patch and the report. Even if this patch was not pushed
to upstream due to a change about large attachments, I am applying it
since it seems correct and small.
-- 
if (user_specified)
    /* Didn't work, but the user is convinced this is the
     * place. */
        2.4.0-test2 /usr/src/linux/drivers/parport/parport_pc.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-roundcube-maintainers/attachments/20120929/4969474f/attachment.pgp>