[Pkg-roundcube-maintainers] 1.3.10

[Guilhem Moulin]

Hi Sandro,

On Wed, 18 Dec 2019 at 01:41:15 +0100, Guilhem Moulin wrote:
> On Wed, 18 Dec 2019 at 01:28:22 +0100, Sandro Knauß wrote:
>> I saw, that you are active packaging 1.4.1, great. I uploaded 1.3.10 today to 
>> unstable and this should reach testing, so I can request an stable update. So 
>> please wait for some days, before you upload 1.4.1 to unstable, that would be 
>> help me.
> 
> Ack, didn't plan to upload before next week anyway. At that point
> the package should be in testing already.

Actually I'll upload to experimental before that, can't hurt to 1.4.1
there I guess.  AFAICT you didn't push the tag ‘debian/1.3.10+dfsg.1-1’,
could you please do it? :-)

Regarding your addition of debian/salsa-ci.yml at 0cb1841, AFAICT it
causes false positives when the upgrade path requires an SQL schema
change.  Compare the 1.3.8+dfsg.1-2 → 1.3.10+dfsg.1-1+salsaci1 upgrade
path from https://salsa.debian.org/roundcube-team/roundcube/-/jobs/462203/raw

    The following packages will be upgraded:
      roundcube-core roundcube-mysql
    2 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    Need to get 0 B/2080 kB of archives.
    After this operation, 2044 kB disk space will be freed.
    Get:1 file:/var/lib/local-apt-repository ./ roundcube-core 1.3.10+dfsg.1-1+salsaci1 [2000 kB]
    Get:2 file:/var/lib/local-apt-repository ./ roundcube-mysql 1.3.10+dfsg.1-1+salsaci1 [79.5 kB]
    […]
    Preparing to unpack .../roundcube-core_1.3.10+dfsg.1-1+salsaci1_all.deb ...
    W: use of dbc preinst hooks is now unnecesary and deprecated.
    Unpacking roundcube-core (1.3.10+dfsg.1-1+salsaci1) over (1.3.8+dfsg.1-2) ...
    Preparing to unpack .../roundcube-mysql_1.3.10+dfsg.1-1+salsaci1_all.deb ...
    Unpacking roundcube-mysql (1.3.10+dfsg.1-1+salsaci1) over (1.3.8+dfsg.1-2) ...
    Setting up roundcube-mysql (1.3.10+dfsg.1-1+salsaci1) ...
    Setting up roundcube-core (1.3.10+dfsg.1-1+salsaci1) ...
    dbconfig-common: writing config to /etc/dbconfig-common/roundcube.conf
    dbconfig-common: flushing administrative password
    This instance of Roundcube is up-to-date.
    Have fun!

with the 1.3.10+dfsg.1-1 → 1.4.1+dfsg.1-1+salsaci1 upgrade path from
https://salsa.debian.org/roundcube-team/roundcube/-/jobs/462775/raw

    The following packages will be upgraded:
      roundcube-core roundcube-mysql
    2 upgraded, 9 newly installed, 0 to remove and 0 not upgraded.
    Need to get 3091 kB/6126 kB of archives.
    After this operation, 16.2 MB of additional disk space will be used.
    […]
    Get:4 file:/var/lib/local-apt-repository ./ roundcube-core 1.4.1+dfsg.1-1+salsaci1 [2950 kB]
    Get:5 file:/var/lib/local-apt-repository ./ roundcube-mysql 1.4.1+dfsg.1-1+salsaci1 [84.9 kB]
    […]
    Preparing to unpack .../08-roundcube-core_1.4.1+dfsg.1-1+salsaci1_all.deb ...
    W: use of dbc preinst hooks is now unnecesary and deprecated.
    Unpacking roundcube-core (1.4.1+dfsg.1-1+salsaci1) over (1.3.10+dfsg.1-1) ...
    Preparing to unpack .../09-roundcube-mysql_1.4.1+dfsg.1-1+salsaci1_all.deb ...
    Unpacking roundcube-mysql (1.4.1+dfsg.1-1+salsaci1) over (1.3.10+dfsg.1-1) ...
    […]
    Setting up roundcube-mysql (1.4.1+dfsg.1-1+salsaci1) ...
    Setting up roundcube-core (1.4.1+dfsg.1-1+salsaci1) ...
    Installing new version of config file /etc/roundcube/defaults.inc.php ...
    Installing new version of config file /etc/roundcube/htaccess ...
    dbconfig-common: writing config to /etc/dbconfig-common/roundcube.conf
    creating database backup in /var/cache/dbconfig-common/backups/roundcube_1.3.10+dfsg.1-1.2019-12-18-05.07.02.
    ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2).
    unable to connect to mysql server.
    dumping database as user failed, retrying with administrator credentials.
    ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2).
    unable to connect to mysql server.
    error encountered backing up the old database:
    ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
    dbconfig-common: roundcube configure: aborted.
    dbconfig-common: flushing administrative password
    dpkg: error processing package roundcube-core (--configure):
     installed roundcube-core package post-installation script subprocess returned error exit status 1
    Errors were encountered while processing:
     roundcube-core

AFAICT this is all because ‘roundcube-mysql’ is the first alternative,
but mysqld hasn't been configured in the container, so dbconfig fails to
upgrade the schema.  (The original schema creation fails as well, but
for whatever reason this is non-fatal.)  When I run piupart locally I
force the installation of ‘roundcube-sqlite3’ to avoid pulling -mysql:
`piuparts … --apt roundcube{-sqlite3,-core,-plugins,}=1.4.1+dfsg.1-1`.
I'm not so familiar with salsa-ci, do you know if something similar is
doable there?   Otherwise, piuparts.d.o has some custom scripts to
install and pre-configure the RDBMS, which maybe salsa-ci could use as
well:

    https://salsa.debian.org/debian/piuparts/blob/buster/custom-scripts/scripts/pre_install_database-server#L157

I suppose we could also use -sqlite3 as first alternative, but that
sounds like a potentially breaking change (at the very least it'll break
third-party tutorials) so I'm not sure I wanna go down that way.

Either way, I'll treat this as a false positive and proceed with the
upload to experimental later today  (and later to sid once 1.3.10 has
reached testing).

-- 
Guilhem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20191218/514b66f5/attachment.sig>