[Pkg-roundcube-maintainers] Bug#988236: roundcube-core: Install breaks lighttpd if fastcgi-php-fpm module is active

[Guilhem Moulin]

Control: reassign -1 roundcube-core 1.4.11+dfsg.1-3

On Sat, 08 May 2021 at 09:07:26 -0300, Kurt Fitzner via Pkg-roundcube-maintainers wrote:
> On systems with lighttpd, the installer should detect if fastcgi-php-fpm is
> already active and if so, should not subsequently activate fastcgi-php.

Thanks, this is related to #898040.

> I'm not sure this shouldn't have a higher severity, but I'll let you judge.

Like #898040 I don't think this warrants RC severity.  But should a fix
make it in time it's definitely suitable to request an unblock request.

That said I'm not sure to how to fix this.  I'm not really familiar with
lighttpd but I don't see a way to list enabled modules other than
looking in /etc/lighttpd/conf-enabled which I'm not really keen to do.

In fact I'm not sure it's a roundcube-core issue in the first place:
`lighty-enable-mod fastcgi-php` arguably should do some sanity check,
otherwise what's the advantage compared to manually creating symlinks?
In a minimal sid chroot:

    $ apt install -y lighttpd php-fpm
    […]
    $ service lighttpd start
    Starting web server: lighttpd.
    $ lighty-enable-mod fastcgi-php-fpm
    Met dependency: fastcgi
    Enabling fastcgi-php-fpm: ok
    Enabling fastcgi: ok
    Run "service lighttpd force-reload" to enable changes
    $ service lighttpd force-reload
    Reloading web server configuration: lighttpd.
    $ lighty-enable-mod fastcgi-php
    Enabling fastcgi-php: ok
    Run "service lighttpd force-reload" to enable changes
    $ echo $?
    0
    $ service lighttpd force-reload
    Duplicate array-key '.php'
    2021-05-09 12:52:17: configfile.c.1970) source: /etc/lighttpd/conf-enabled/15-fastcgi-php.conf line: 21 pos: 1 parser failed somehow near here: (EOL)
    2021-05-09 12:52:17: configfile.c.1970) source: /etc/lighttpd/lighttpd.conf line: 51 pos: 15 parser failed somehow near here: (EOL)

If these modules are incompatible lighty-enable-mod(1) should ideally
give a hint.  I see module snippets have a way to express dependencies,
but unfortunately not conflicts.

lighttpd maintainers (CC'ed): What's the best way to express “enable
fastcgi-php (or fastcgi-php-fpm) unless fastcgi.server already has a
handler for .php”?  Or if that's not possible “enable fastcgi-php unless
fastcgi-php-fpm is already enabled”?  Simply expand
/etc/lighttpd/conf-enabled/*-fastcgi-php-fpm.conf and check for a match,
or is there a more robust way?

Thanks!
-- 
Guilhem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20210509/ba4c9ce4/attachment.sig>