[Pkg-roundcube-maintainers] Bug#994128: roundcube: search preference configuration setting for folder scope gets ignored

[Guilhem Moulin]

Control: tag -1 moreinfo

Hi,

On Sun, 12 Sep 2021 at 08:19:10 -0400, Steve Dondley via Pkg-roundcube-maintainers wrote:
> I set the $config['search_scope'] to a value of 'all' in the configuration
> file so that the "Scope" field should default to "All folders." This feature
> is broken. When switching folders, the search scope in the search form gets reset to
> "Current folder". A manual refresh of the web page is required to get the
> desired setting of "All folders".

Are you suggesting that we should apply

--8<--------------------------------------------------------------------->8--
--- a/program/js/app.js
+++ b/program/js/app.js
@@ -5672,7 +5672,7 @@ function rcube_webmail()
   {
     var n, url = {}, mods_arr = [],
       mods = this.env.search_mods,
-      scope = this.env.search_scope || 'base',
+      scope = this.env.search_scope || 'all',
       mbox = this.env.mailbox;
 
     if (!filter && this.gui_objects.search_filter)
--8<--------------------------------------------------------------------->8--

?  If so, please reopen your upstream issue, and this Debian bug should
tagged ‘upstream’ and marked as forwarded to the GitHub issue.
 
> * What exactly did you do (or not do) that was effective
> 
> While investigating the issue, I discovered that overwriting the minified 
> app.min.js with the non-minified app.js file resolved the problem. It appears
> the app.min.js is probably using a stale version of app.js.

Minifying (and static pre-compression) happens at built time.  When a
source file is manually changed, the generated files that depend on it
need to be manually updated too.  The app.min.js file we *shipped*
matched the original app.js, right?  If so, that's not a bug.

cheers
-- 
Guilhem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20210912/6b889bca/attachment.sig>