[Pkg-roundcube-maintainers] Bug#1068465: plugin thunderbird_labels and keyboard_shortcuts causing traces

[Christian Schwamborn]

Package: roundcube-plugins-extra
Version: 1.4.10+1-4

I got an error like this, trying to set a message Flag:

[05-Apr-2024 15:16:54 UTC] PHP Warning:  Undefined property:
rcmail::$imap in
/usr/share/roundcube/plugins/thunderbird_labels/thunderbird_labels.php
on line 318
[05-Apr-2024 15:16:54 UTC] PHP Fatal error:  Uncaught TypeError:
array_merge(): Argument #1 must be of type array, null given in
/usr/share/roundcube/plugins/thunderbird_labels/thunderbird_labels.php:327

I think the issue is in function set_flags, around line 318 is a
definition '$imap = $this->rc->imap;'.
The object $this->rc->imap seems to be renamed to $this->rc->storage.
Changing this one line fixed the issue for me.

The same issue can be found in keyboard_shortcuts.
Replacing '$rcmail->imap' with '$rcmail->storage' between lines 104 and
109 fixes the issue there.