[Pkg-roundcube-maintainers] Bug#1078776: roundcube-core: Contacts import: Contacts with matching e-mail address treated as duplicates

[Einhard Leichtfuß]

Package: roundcube
Version: 1.6.5+dfsg-1+deb12u4
Severity: normal

Dear Maintainer,

when importing contacts from a vCard file that contains two vcard
objects with the same e-mail address, or one vcard object with an e-mail
address that is already assigned to an existing contact, the contacts
are treated as duplicates and one of them is not imported, with the
message "Skipped 1 existing entries: [...]".

This does not happen if "Replace the entire address book" is activated
on importing.

I would expect that a contact is only skipped on import if it would be
an exact duplicate of another contact.

Further, I would expect that duplicates within a file are treated the
same regardless of whether "Replace the entire address book" is
activated on importing.

Example (note that vCard mandates CRLF as newline sequence):
---
BEGIN:VCARD
VERSION:3.0
N:Doe;Jane;;;
FN:Jane Doe
EMAIL:doe at example.net
END:VCARD
BEGIN:VCARD
VERSION:3.0
N:Doe;John;;;
FN:John Doe
EMAIL:doe at example.net
END:VCARD
---

Result of importing above example:

* "Successfully imported 1 contacts: Jane Doe"
* "Skipped 1 existing contacts: John Doe"
* Only the record for "Jane Doe" is imported.


- Einhard Leichtfuß


-- System Information:
Debian Release: 12.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-23-cloud-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages roundcube-core depends on:
ii  dbconfig-common                 2.0.24
ii  debconf [debconf-2.0]           1.5.82
ii  dpkg                            1.21.22
ii  libjs-bootstrap4                4.6.1+dfsg1-4
ii  libjs-codemirror                5.65.0+~cs5.83.9-2
ii  libjs-jquery                    3.6.1+dfsg+~3.5.14-1
ii  libjs-jquery-minicolors         2.3.5+dfsg-4
ii  libjs-jquery-ui                 1.13.2+dfsg-1
ii  libjs-jstimezonedetect          1.0.7+~1.0.3-1
ii  libmagic1                       1:5.44-3
ii  php                             2:8.2+93
ii  php-auth-sasl                   1.1.0-1
pn  php-cli                         <none>
ii  php-common                      2:93
ii  php-guzzlehttp-guzzle           7.4.5-1
ii  php-intl                        2:8.2+93
ii  php-mail-mime                   1.10.11-1
ii  php-masterminds-html5           2.7.6+dfsg-1
ii  php-mbstring                    2:8.2+93
ii  php-net-sieve                   1.4.6-1
ii  php-net-smtp                    1.10.1-1
ii  php-pear                        1:1.10.13+submodules+notgz+2022032202-2
ii  php8.2 [php]                    8.2.20-1~deb12u1
ii  php8.2-cli [php-json]           8.2.20-1~deb12u1
ii  php8.2-fpm [php-json]           8.2.20-1~deb12u1
ii  php8.2-intl [php-intl]          8.2.20-1~deb12u1
ii  php8.2-mbstring [php-mbstring]  8.2.20-1~deb12u1
ii  roundcube-pgsql                 1.6.5+dfsg-1+deb12u4
ii  ucf                             3.0043+nmu1

Versions of packages roundcube-core recommends:
ii  nginx [httpd-cgi]             1.22.1-9
ii  php-enchant                   2:8.2+93
ii  php-fpm                       2:8.2+93
pn  php-gd                        <none>
ii  php8.2-enchant [php-enchant]  8.2.20-1~deb12u1
ii  php8.2-fpm [php-fpm]          8.2.20-1~deb12u1
pn  roundcube-skin-classic        <none>
ii  roundcube-skin-larry          1.6.0+ds-2

Versions of packages roundcube-core suggests:
pn  php-bacon-qr-code           <none>
pn  php-bjeavons-zxcvbn-php     <none>
pn  php-crypt-gpg               <none>
pn  php-net-ldap3               <none>
pn  php-roundcube-rtf-html-php  <none>
pn  roundcube-plugins           <none>

Versions of packages roundcube depends on:
ii  dpkg  1.21.22

-- Configuration Files:
/etc/cron.d/roundcube-core changed:
MAILTO=root
0 5 * * * www-data test -d /run/systemd/system || /usr/share/roundcube/bin/cleandb.sh >/dev/null
5,35 * * * * www-data test -d /run/systemd/system || /usr/share/roundcube/bin/gc.sh


-- debconf information:
  roundcube/upgrade-backup: true
  roundcube/pgsql/method: TCP/IP
  roundcube/db/dbname: roundcube
  roundcube/db/app-user: roundcube at localhost
  roundcube/remote/port:
  roundcube/pgsql/no-empty-passwords:
  roundcube/hosts: localhost:143
  roundcube/dbconfig-reinstall: false
  roundcube/language: en_US
  roundcube/passwords-do-not-match:
  roundcube/dbconfig-remove: true
  roundcube/remote/newhost: localhost
  roundcube/pgsql/authmethod-admin: ident
  roundcube/pgsql/changeconf: false
  roundcube/pgsql/authmethod-user: password
  roundcube/internal/skip-preseed: false
  roundcube/pgsql/manualconf:
  roundcube/remote/host: localhost
  roundcube/purge: false
* roundcube/dbconfig-install: false
  roundcube/dbconfig-upgrade: true
  roundcube/pgsql/admin-user: postgres
  roundcube/reconfigure-webserver: apache2, lighttpd
  roundcube/internal/reconfiguring: false
  roundcube/remove-error: abort
  roundcube/database-type: pgsql
  roundcube/install-error: abort
  roundcube/missing-db-package-error: abort
  roundcube/restart-webserver: true
  roundcube/upgrade-error: abort