[Pkg-roundcube-maintainers] Bug#1063835: roundcube: When upgrading from roundcube 1.4.15+dfsg.1-1~deb11u2 to 1.6.5+dfsg-1~deb12u1 error "table roundcube.filestore does not exist" is thrown, not handled

[Guilhem Moulin]

Control: reassign -1 roundcube-mysql
Control: tag - 1 unreproducible

On Tue, 13 Feb 2024 at 11:47:12 +0000, Andrew Gallagher via Pkg-roundcube-maintainers wrote:
> When upgrading roundcube to the latest version, the mariadb schema
> upgrade fails due to a missing table "roundcube.filestore".
> This table apparently never existed, however this did not seem to
> cause any noticeable issues before the upgrade.

It definitely is part of the schema and should have been created when
you installed roundcube-mysql ≥1.4.1-1 or upgraded from <1.4.  Piuparts
doesn't croak either.

> It appears therefore that the schema migration makes too many assumptions about the state of the current database,
> and so does not handle the missing (but apparently optianal) table
> gracefully. Missing tables should be created if they do not exist..

Schema upgrades come from upstream so that would be a (wishlist)
upstream bug.  When using roundcube-{mysql,pgsql,sqlite3} I think it's
reasonable to assume the schema version based on the roundcube version
alone.  dbconfig has no way to guess if/how the database has been
manually tampered with, and I'm not sure a more robust migration is even
doable reliably as it's not only about table creation but also indices,
foreign keys, types and constraints on columns etc.

-- 
Guilhem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20240213/c7e44ed5/attachment.sig>