[Pkg-roundcube-maintainers] Bug#1150492: roundcube: FTBFS with PHP 8.5: TypeError in test_array_first

[Viktor Pashaiev]

Package: roundcube
Version: 1.6.19+dfsg-1
Severity: normal
Tags: patch ftbfs
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu stonking ubuntu-patch

Dear Maintainer,

Under PHP 8.5, array_first(array $array) is a strictly typed native function.
Framework_Bootstrap::test_array_first asserted that non-array arguments
(false, string) return null, which now throws TypeError:
  TypeError: array_first(): Argument #1 ($array) must be of type array, false given

This causes the package test suite to fail under PHP 8.5.

Upstream resolved this in commit 060fc95672498993d37e57f74d146a087eb572e0
by dropping the non-array assertions from the test.

Attached is a patch backporting the upstream fix.

Thanks,
Viktor Pashaiev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: php8.5-array-first-compat.patch
Type: application/x-diff
Size: 1166 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20261010/73fbe7ea/attachment.bin>