[DRE-maint] RFS : redmine

[Ryan Niebur]

Hi!

this review is not complete yet. I haven't even built or install it
yet, and I've just briefly looked around the packaging.

On Wed, Jul 08, 2009 at 05:57:12PM +0200, Jérémy Lal wrote:
> Hi,
> i uploaded on svn [0] my (and R.Hurt) work on the redmine
> package. The corresponding package (in sync with the
> repository) is also available on mentors, see [1].
>
> It it worth noting that :
> * redmine 0.8.x doesn't work with any rails package available
> in debian, so the only possible target is redmine 0.9, which is
> rails 2.2 compatible.
> * the patches against upstream are needed only to put files in the
> right places (/etc/redmine/, /var/cache/redmine, /var/log/redmine,
> /var/lib/redmine)
> * the database setup is managed by dbconfig-common, and provides
> mysql, pgsql, sqlite support.

if the ruby bindings to one of these is not installed, will the user
still get the option of that database? if so, then what will happen?
will it error out and cause the install to fail? it shouldn't. it
should probably only offer the user the choices for the ruby bindings
installed. and maybe explain to them how to install more and set it up
again.

> * other configuration (web server, email) is left to the
> web admin, with some examples provided in the docs.
>
> I would be pleased to see that package make its way to debian,
> and i'd be glad to hear about any suggestion to improve it.
>

- there are some files listed in d/copyright that look like this:
   Files: lib/diff.rb
   Copyright: Copyright 2001 Lars Christensen
   License: none
  that won't cut it, they need a license that allows them to be
  distributed. your options are contacting the upstream author (in
  this case Lars Christensen) or making it so that redmine doesn't
  need it (either by making the feature use an alternate library or
  by making the feature optional and disabled in the debian package,
  and repacking to remove that file from the original tarball).
  Including an email from Lars would be enough, tho it would probably
  be better to get the license information added to the comments in
  diff.rb itself (upstream, you can't really patch in this kind of thing).
- you say that debian/doc/wiki.html is exported from redmine's wiki.
  what about it's license and copyright?
- the default ruby db binding is libdbd-pg-ruby, while the default
  database client is mysql-client. these should probably match..
- would defaulting to sqlite be better? it's lighter than mysql and
  postgres. this is up to you and just a suggestion.
- the dependency on httpd-cgi doesn't include thin, and I would like
  it to :). are there other cases like this? mongrel/mongrel-cluster
  at least could probably be used, yes? and passenger (once it's
  packaged, I wonder what happened with this..). assuming that there's
  no reason why redmine wouldn't work with these, I will provide an
  example thin configuration when I test the package, that you can
  include if you like.
- some lintian output:
  P: redmine source: debian-control-has-unusual-field-spacing line 7
  I: redmine source: quilt-patch-missing-description 02_production_env_and_path_config.patch
  I: redmine source: quilt-patch-missing-description 03_email_path_config.patch
  I: redmine source: quilt-patch-missing-description 04_files_path_config.patch
  I: redmine source: quilt-patch-missing-description 05_sessions_path_config.patch
  I: redmine source: quilt-patch-missing-description 06_fastcgilog_path_config.patch
- you based your packaging off of Richards, right? so then his
  copyright statement should be added back to debian/copyright
- echoed messages:
  d/TODO says this:
  - use templates for all echoed messages (but not displayed using debconf)
  why not? people probably won't notice echoed messages, especially
  people installing with GUIs.
- are you building this package onto redmines website or elsewhere?
  if not, what's the reason for debian/changelog being so long? it
  should probably be reduced to just a single entry for the Debian
  package.

Cheers,
Ryan

-- 
_________________________
Ryan Niebur
ryanryan52 at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20090712/36d955dc/attachment.pgp>