[DRE-maint] Bug#550539: mongrel-cluster: Incorrect init.d script dependencies and runlevels

[Petter Reinholdtsen]

Package:  mongrel-cluster
Version:  1.0.5-1
Severity: serious
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency incorrect-runlevels

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts of this package.  The dependency list is
incomplete.  It uses files in /usr/ and should depend on $remote_fs,
and it used to start after syslog and should probably continue to do
so.  The runlevel list is empty, and this do not reflect the arguments
used by update-rc.d.

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the script will fail
to start during boot and stop during shutdown.  Please upload a fix
for this into unstable soon or object if we should not NMU to solve
this issue.

diff -ur ../mongrel-cluster-1.0.5/debian/mongrel-cluster.init ../mongrel-cluster-1.0.5-pere/debian/mongrel-cluster.init
--- ../mongrel-cluster-1.0.5/debian/mongrel-cluster.init        2009-10-10 14:59:08.000000000 +0200
+++ ../mongrel-cluster-1.0.5-pere/debian/mongrel-cluster.init   2009-10-10 23:34:12.000000000 +0200
@@ -1,13 +1,13 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          mongrel-cluster
-# Required-Start:
-# Required-Stop:
-# Default-Start:
-# Default-Stop:
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Should-Start:      $network
 # Should-Stop:       $network
 # Short-Description: Start mongrel servers at boot time
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 ### END INIT INFO
 #
 # Copyright (c) 2007 Bradley Taylor, bradley at railsmachine.com

Happy hacking,
-- 
Petter Reinholdtsen