[DRE-maint] liboauth-ruby: initial upload for review

[Lucas Nussbaum]

On 01/03/10 at 02:04 +0200, Will Daniels wrote:
> Hello,
> 
> I have uploaded a new package liboauth-ruby for somebody to review
> please. This is my first attempt, so be kind :P

Well, for a first attempt, you did very well!

It is very important to use svn-inject to import the package into SVN.
The way you imported it, the mergeWithUpstream SVN property wasn't set,
so svn-buildpackage & friends refused to work.  (fixed)

debian/rules:
install/liboauth-ruby1.8::
	dh_installchangelogs -pliboauth-ruby1.8 History.txt
Can probably be replaced by:
DEB_INSTALL_CHANGELOGS_liboauth-ruby1.8 := History.txt

(but I haven't checked)

Lintian warning:
W: liboauth-ruby source: out-of-date-standards-version 3.8.3 (current is
3.8.4)

You might want to add a comment following DEP4 for
debian/patches/repack-deprecate-rubygems. Even if the patch is very
simple, it's still a good practice.

> A few notes:
> 
> 1. I did not add a ruby 1.9.1 package because it depends on libhmac-ruby
> which doesn't appear to have one yet.

That's fine.

> 2. I was not entirely sure what to do with the tests, namely whether to
> package them along with the lib or the docs, or where in the rules to
> run them in the build. I ran them locally and it all seems to work fine,
> but aside from that I have ditched them for now :$

Unfortunately, it seems that we often lack packages for some of the
libraries required to run ruby tests.

> 3. The upstream sources include scripts to generate the lib's homepage
> on rubyforge. I did not think it of value to attempt to package this for
> docs or anything else. For starters, it begins with instructions to
> "sudo gem install oauth" etc.

That's probably fine. Is there any reason to believe that the copyright
would be different here?

> 4. I get some warnings during build, while generating the rdoc, like this:
> 
> (process:3567): Pango-WARNING **: error opening config file
> '/root/.pangorc': Permission denied
> 
> I think it has to do with graphviz generating it's diagrams, perhaps
> looking for some fonts or screen metrics?. It seems harmless enough in
> that the diagrams look fine to me, but perhaps one of you knows
> differently? Or maybe someone knows how to suppress that cleanly?

looks harmless.
-- 
| Lucas Nussbaum
| lucas at lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas at nussbaum.fr             GPG: 1024D/023B3F4F |