[DRE-maint] Bug#649489: Bug#649489: Bug#649489: ruby-rdiscount: use system libmarkdown2 instead of embedded one

[Cédric Boutillier]

Hi,

On Sat, Nov 26, 2011 at 01:36:15PM +0100, Alessandro Ghedini wrote:
> On Wed, Nov 23, 2011 at 09:25:05AM +0100, Martin Ueding wrote:
> > ruby-rdiscount was designed to be distributed by ruby gems as far as I
> > understand the upstream project page. Therefore, I assume that this
> > would have to be fixed in Debian since we use our own packaging system.
> > 
> > I do not know Ruby, so I cannot supply a patch which splits off the
> > discount and uses the Debian version instead.

> I'm not into Ruby either, maybe someone from the pkg-ruby-extras team may
> provide some help?

It is possible to build ruby-rdiscount against libmarkdown2-dev, by
deleting the convenience copy of discount from the package (everything
in ext/ except config.h, extconf.rb and rdiscount.c) and add the
following line in extconf.rb with a patch:

have_library('markdown')

However, rdiscount seems to expect a different version of
discount/libmarkdown2,
because two of the tests fail. I get the following error, which
is certainly due to a change in conventions in discount (dot instead of
+) :


---------
Failure:
test_should_get_the_generated_toc(RDiscountTest)
[./test/rdiscount_test.rb:57]:
<"<ul>\n <li><a href=\"#Level+1\">Level 1</a>\n  <ul>\n  <li><a
href=\"#Level+2\">Level 2</a>  </li>\n  </ul>\n </li>\n </ul>"> expected
but was
<"<ul>\n <li><a href=\"#Level.1\">Level 1</a></li>\n <li><ul>\n  <li><a
href=\"#Level.2\">Level 2</a></li>\n </ul></li>\n</ul>">.

diff:
  <ul>
  -  <li><a href="#Level+1">Level 1</a>
  ?                     ^
  +  <li><a href="#Level.1">Level 1</a></li>
  ?                     ^              +++++
  -   <ul>
  +  <li><ul>
  -   <li><a href="#Level+2">Level 2</a>  </li>
  ?                      ^              --
  +   <li><a href="#Level.2">Level 2</a></li>
  ?                      ^
  +  </ul></li>
  -   </ul>
  -  </li>
  -  </ul>
  ? -
  + </ul>

  ..F

Failure:
test_that_generate_toc_sets_toc_ids(RDiscountTest)
[./test/rdiscount_test.rb:51]:
<"<h1 id=\"Level+1\">Level 1</h1>\n\n<h2 id=\"Level+2\">Level
2</h2>\n"> expected but was
<"<h1 id=\"Level.1\">Level 1</h1>\n\n<h2 id=\"Level.2\">Level
2</h2>\n">.

diff:
  - <h1 id="Level+1">Level 1</h1>
  ?              ^
  + <h1 id="Level.1">Level 1</h1>
  ?              ^
   
  - <h2 id="Level+2">Level 2</h2>
  ?              ^
  + <h2 id="Level.2">Level 2</h2>
  ?              ^
-----
One could patch the tests and document it in a Readme.Debian, but I am
not sure that it is the correct thing to do. Probably this has to be
reported upstream, so that they release a new version compatible with
the newest version of discount.

Best regards,

	Cédric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20111130/5f159166/attachment.pgp>