[DRE-maint] Tests fail on ruby-mustache

[Cédric Boutillier]

On Mon, Oct 10, 2011 at 08:20:43PM +0200, Martin Ueding wrote:
> For me, it does not work without the patch. I changed the patch to
> include lib/mustache.rb and all the tests succeed on my Unstable VM. The
> changes are pushed to master.

> Can we build and upload this now?

I really believe that this patch is not needed when the test suite is
run during the package build. The script test-runner.rb is modifying the
$LOAD_PATH to include debian/ruby-mustache//usr/lib/ruby/vendor_ruby
which will contain a copy of the library mustache(.rb) in lib/.
Moreover there is a (not needed, in fact) statement in the test that
adds to $LOAD_PATH that lib/ directory. So that is two reasons to leave
the "require" statements as they are. I tested again, and it builds
perfectly with test-pwd commented out in debian/patches/series.

I am not sure that the dependencies are set correctly. It does not
depend on ruby-test-unit. It does even not build-depends on it: (what is
bundled with the interpreter is enough to run the tests).
However, the file lib/mustache/sinatra requires sinatra/base, so you
should add ruby-sinatra. Some files have to do with ruby-rack without
requiring it, so you could for example add it as a Suggests.

Best wishes,

	Cédric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20111010/c475a170/attachment.pgp>