[DRE-maint] Bug#684421: FTBFS: tests require internet connectivity

[Felix Geyer]

Source: ruby-net-http-persistent
Version: 2.7-1
Severity: serious
Tags: sid, wheezy
Justification: fails to build from source

This package requires internet connectivity for its test suite
to pass. Package builds should not rely on external network
connectivity, but should be self-contained.

Just removing the three affected methods from test/test_net_http_persistent.rb
seems to work but I'm not sure if that's the right thing to do.


Build log:

# Running tests:

....E........................S........................E..E...........................

Finished tests in 0.790200s, 106.3022 tests/s, 354.3407 assertions/s.

  1) Error:
test_connection_for_http_class_with_fakeweb(TestNetHttpPersistent):
SocketError: getaddrinfo: Name or service not known
    /usr/lib/ruby/1.8/net/http.rb:560:in `initialize'
    /usr/lib/ruby/1.8/net/http.rb:560:in `open'
    /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    /usr/lib/ruby/1.8/timeout.rb:53:in `timeout'
    /usr/lib/ruby/1.8/timeout.rb:101:in `timeout'
    /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    /usr/lib/ruby/1.8/net/http.rb:553:in `do_start'
    /usr/lib/ruby/1.8/net/http.rb:548:in `start'
    ./debian/ruby-net-http-persistent//usr/lib/ruby/vendor_ruby/net/http/persistent.rb:511:in `connection_for'
    ./test/test_net_http_persistent.rb:358:in `test_connection_for_http_class_with_fakeweb'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:1058:in `run_test'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:1058:in `run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:823:in `_run_suite'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:815:in `map'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:815:in `_run_suite'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `_run_suites'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `map'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `_run_suites'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:775:in `_run_anything'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:964:in `run_tests'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:951:in `send'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:951:in `_run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:950:in `each'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:950:in `_run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:939:in `run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:697:in `autorun'
    -e:1

  2) Error:
test_connection_for_no_ssl_reuse(TestNetHttpPersistent):
SocketError: getaddrinfo: Name or service not known
    /usr/lib/ruby/1.8/net/http.rb:560:in `initialize'
    /usr/lib/ruby/1.8/net/http.rb:560:in `open'
    /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    /usr/lib/ruby/1.8/timeout.rb:67:in `timeout'
    /usr/lib/ruby/1.8/timeout.rb:101:in `timeout'
    /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    /usr/lib/ruby/1.8/net/http.rb:553:in `do_start'
    /usr/lib/ruby/1.8/net/http.rb:548:in `start'
    ./debian/ruby-net-http-persistent//usr/lib/ruby/vendor_ruby/net/http/persistent.rb:511:in `connection_for'
    ./test/test_net_http_persistent.rb:391:in `test_connection_for_no_ssl_reuse'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:1058:in `run_test'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:1058:in `run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:823:in `_run_suite'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:815:in `map'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:815:in `_run_suite'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `_run_suites'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `map'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `_run_suites'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:775:in `_run_anything'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:964:in `run_tests'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:951:in `send'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:951:in `_run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:950:in `each'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:950:in `_run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:939:in `run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:697:in `autorun'
    -e:1

  3) Error:
test_connection_for_http_class_with_webmock(TestNetHttpPersistent):
SocketError: getaddrinfo: Name or service not known
    /usr/lib/ruby/1.8/net/http.rb:560:in `initialize'
    /usr/lib/ruby/1.8/net/http.rb:560:in `open'
    /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    /usr/lib/ruby/1.8/timeout.rb:53:in `timeout'
    /usr/lib/ruby/1.8/timeout.rb:101:in `timeout'
    /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
    /usr/lib/ruby/1.8/net/http.rb:553:in `do_start'
    /usr/lib/ruby/1.8/net/http.rb:548:in `start'
    ./debian/ruby-net-http-persistent//usr/lib/ruby/vendor_ruby/net/http/persistent.rb:511:in `connection_for'
    ./test/test_net_http_persistent.rb:368:in `test_connection_for_http_class_with_webmock'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:1058:in `run_test'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:1058:in `run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:823:in `_run_suite'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:815:in `map'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:815:in `_run_suite'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `_run_suites'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `map'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:802:in `_run_suites'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:775:in `_run_anything'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:964:in `run_tests'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:951:in `send'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:951:in `_run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:950:in `each'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:950:in `_run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:939:in `run'
    /usr/lib/ruby/vendor_ruby/minitest/unit.rb:697:in `autorun'
    -e:1

84 tests, 280 assertions, 0 failures, 3 errors, 1 skips
ERROR: Test "ruby1.8" failed. Exiting.