[DRE-maint] Bug#684421: Bug#684421: FTBFS: tests require internet connectivity

[Felix Geyer]

Hi,

On 10.08.2012 02:04, Gunnar Wolf wrote:
> Hi Felix,
> 
> Thanks for the report - I also am not sure of the action to take, so I'm asking the rest of
> the team for input here. Looking at the source, I see quite often the mention of:
> 
> c = @http.connection_for @uri
> 
> where @uri is often defined as 'https://example.com/path'. I am surprised the tests failed
> for you only three times — How are you checking for network connectivity? Just running in an
> environment with no networking defined? FWIW, I tested the build killing my default gateway,
> and the tests now succeed (or are skipped).

I recently switched from iptables rules that reject packets from the
pbuilder user to network namespaces.
So pbuilder only has access to a virtual network device where it can
reach my apt-cacher-ng instance.

With the patch you attached the package builds fine for me as well.

> It would be good to build with network access. But it is sometimes impossible. And the
> network is a changing thing outside our control. So, yes, not having network access should
> not make the test fail - and the only way out is to report it as such.

Ideally the package would start a local HTTP(S) server and do
s/example.com/localhost/ in the tests.

Felix

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20120810/2c96a754/attachment.pgp>