[DRE-maint] Bug#676206: ruby-gruff: fixed in the Ruby Team repository

Cédric Boutillier cedric.boutillier at gmail.com
Mon Jul 23 12:12:00 UTC 2012


Package: ruby-gruff
Followup-For: Bug #676206


Dear Nobuhiro,

Thank you for working on this issue. The bug is simply caused by the fact that
taking the modulo with respect to 0.0 gives an "Division by zero" error
with Ruby1.9, but raises no error and return NaN with Ruby1.8.

This has been discussed upstream [1], and the corresponding code has been
merged [2].

The patch you proposed for supporting 1.9.3 contains this fix, but also
many modifications that did not appear in upstream release (other than
the upstream VCS). They contain code such that 'require "rubygems"' that
are not suitable for Debian Ruby packages.

Ignoring the test results for Ruby 1.9 is also not satisfactory, I am
afraid.

It occurs that the 'freeze_exception' branch of Git repository for the
Debian packaging of ruby-gruff [3] includes the patch [2] cherrypicked
from upstream. It is waiting for review and upload [4]. I should have
tagged this bug as pending and fixed-upstream, which I am doing now.

  1: https://github.com/topfunky/gruff/issues/21
  2: https://github.com/topfunky/gruff/pull/22
  3: http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-gruff.git;a=summary
  4: http://lists.debian.org/debian-ruby/2012/07/msg00000.html

See debdiff output attached.

Cheers,

Cédric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-gruff_division_by_zero.patch
Type: text/x-diff
Size: 2360 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20120723/f76f1f34/attachment.patch>


More information about the Pkg-ruby-extras-maintainers mailing list