[DRE-maint] Bug#676211: thin: FTBFS: thin.c:82:3: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: thin
Version: 1.3.1-1.1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20120605 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> make[1]: Entering directory `/«PKGBUILDDIR»/ext/thin_parser'
> make[1]: Leaving directory `/«PKGBUILDDIR»/ext/thin_parser'
> /usr/lib/ruby/1.9.1/rubygems/ext/builder.rb:37:in `block in make': make failed: (Gem::InstallError)
> 
> ["/usr/bin/ruby1.9.1 extconf.rb", "checking for main() in -lc... yes\ncreating Makefile\n", "make", "make[1]: Entering directory `/«PKGBUILDDIR»/ext/thin_parser'\ncompiling thin.c\nthin.c: In function 'http_field':\nthin.c:82:3: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c:83:3: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c: In function 'request_uri':\nthin.c:114:3: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c: In function 'fragment':\nthin.c:125:3: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c: In function 'request_path':\nthin.c:136:3: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c: In function 'query_string':\nthin.c:148:3: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c: In function 'Thin_HttpParser_alloc':\nthin.c:243:3: warning: implicit declaration of function 'thin_http_parser_init' [-Wimplicit-function-declaration]\nthin.c: In function 'Thin_HttpParser_finish':\nthin.c:295:3: warning: implicit declaration of function 'thin_http_parser_finish' [-Wimplicit-function-declaration]\nthin.c:297:3: warning: implicit declaration of function 'thin_http_parser_is_finished' [-Wimplicit-function-declaration]\nthin.c: In function 'Thin_HttpParser_execute':\nthin.c:335:5: warning: implicit declaration of function 'thin_http_parser_execute' [-Wimplicit-function-declaration]\nthin.c:337:5: error: format not a string literal and no format arguments [-Werror=format-security]\nthin.c:339:5: warning: implicit declaration of function 'thin_http_parser_has_error' [-Wimplicit-function-declaration]\ncc1: some warnings being treated as errors\nmake[1]: *** [thin.o] Error 1\nmake[1]: Leaving directory `/«PKGBUILDDIR»/ext/thin_parser'\n"]
> 	from /usr/lib/ruby/1.9.1/rubygems/ext/builder.rb:32:in `each'
> 	from /usr/lib/ruby/1.9.1/rubygems/ext/builder.rb:32:in `make'
> 	from /usr/lib/ruby/1.9.1/rubygems/ext/ext_conf_builder.rb:18:in `build'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:62:in `block in build_and_install'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:61:in `chdir'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:61:in `build_and_install'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:75:in `block in build_all_extensions'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:72:in `each'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:72:in `build_all_extensions'
> 	from /usr/lib/ruby/vendor_ruby/gem2deb/extension_builder.rb:88:in `<main>'
> /usr/bin/ruby1.9.1 extconf.rb
> checking for main() in -lc... yes
> creating Makefile
> make
> make[1]: Entering directory `/«PKGBUILDDIR»/ext/thin_parser'
> compiling thin.c
> thin.c: In function 'http_field':
> thin.c:82:3: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c:83:3: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c: In function 'request_uri':
> thin.c:114:3: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c: In function 'fragment':
> thin.c:125:3: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c: In function 'request_path':
> thin.c:136:3: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c: In function 'query_string':
> thin.c:148:3: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c: In function 'Thin_HttpParser_alloc':
> thin.c:243:3: warning: implicit declaration of function 'thin_http_parser_init' [-Wimplicit-function-declaration]
> thin.c: In function 'Thin_HttpParser_finish':
> thin.c:295:3: warning: implicit declaration of function 'thin_http_parser_finish' [-Wimplicit-function-declaration]
> thin.c:297:3: warning: implicit declaration of function 'thin_http_parser_is_finished' [-Wimplicit-function-declaration]
> thin.c: In function 'Thin_HttpParser_execute':
> thin.c:335:5: warning: implicit declaration of function 'thin_http_parser_execute' [-Wimplicit-function-declaration]
> thin.c:337:5: error: format not a string literal and no format arguments [-Werror=format-security]
> thin.c:339:5: warning: implicit declaration of function 'thin_http_parser_has_error' [-Wimplicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [thin.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2012/06/05/thin_1.3.1-1.1_unstable.log

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.