[DRE-maint] RFS: ruby-hiera 0.3.0-1, ruby-hiera-puppet 0.3.0-1

[Christian Hofstaedtler]

Hi Patrick,

Thanks for working on hiera for Debian.

I've taken a quick look at your packages, and have the following
comments:


* debian/ruby-hiera.substvars and debian/ruby-hiera-puppet.substvars
are checked into git, but are cleaned before building the source.
This makes building straight from git fail.

* ruby-hiera has bin/hiera, which has support for loading(?) data
from Puppet and MCollective, but ruby-hiera doesn't
Depend/Recommend/Suggest any of them. I'd suggest to add a
Suggests: puppet-common, mcollective-common to ruby-hiera.

* ruby-hiera-puppet recommends puppet (the client). I'm not sure how
ruby-hiera-puppet exactly integrates into puppet, but if it only
needs to be installed on the master, then I'd suggest to change the
recommends to puppet-common.

* ruby1.8: Now that ruby1.9.1 is the default ruby, it might not be a
good idea to introduce a package that doesn't work on 1.9.x,
especially when the executables say '/usr/bin/env ruby' (which
likely will resolve to ruby1.9.1 on a standard installation).
Upstream has a ticket[1] that 0.3.0 doesn't properly work on 1.9.x,
and indeed you seem to have disabled builds for 1.9.1.
Maybe it's better to package hiera 1.0.0rcX which is supposed to
work on 1.9.x as well.


  -ch


[1] http://projects.puppetlabs.com/issues/10975

-- 
christian hofstaedtler
phone +43 720 699846