[DRE-maint] Bug#730716: tests and build fail if directory name contains a + sign

[Marc Haber]

Package: gem2deb
Version: 0.5.1
Severity: normal

Hi,

the tests and the package build fails if the current directory name
contains a plus sign. This might be the case with certain version
numbering schemes, for example for NMUs (0.5.1+nmu1, dch's default)
and backports. I fell over this while creating a
gem2deb_0.5.1~zgSID+0, as it is required for use with mini-buildd (and
valid!).

This is a clean sid chroot with gem2deb's build dependencies already
installed:

[91/590]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb$ apt-get source
gem2deb
Reading package lists... Done
Building dependency tree
Reading state information... Done
NOTICE: 'gem2deb' packaging is maintained in the 'Git' version control system at:
git://anonscm.debian.org/pkg-ruby-extras/gem2deb.git
Skipping already downloaded file 'gem2deb_0.5.1.dsc'
Skipping already downloaded file 'gem2deb_0.5.1.tar.gz'
Need to get 0 B of source archives.
gpgv: keyblock resource `/home/mh/.gnupg/trustedkeys.gpg': file open error
gpgv: Signature made Thu Nov 21 18:00:25 2013 UTC using RSA key ID CD460BDE
gpgv: Can't check signature: public key not found
dpkg-source: warning: failed to verify signature on ./gem2deb_0.5.1.dsc
dpkg-source: info: extracting gem2deb in gem2deb-0.5.1
dpkg-source: info: unpacking gem2deb_0.5.1.tar.gz
[92/591]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb$ cd gem2deb-0.5.1
/home/mh/packages/gem2deb/gem2deb-0.5.1
[93/592]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb/gem2deb-0.5.1$ /usr/bin/ruby1.9.1 -I"lib:test" -I"/usr/lib/ruby/vendor_ruby" "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/unit/dh_make_ruby_test.rb" "test/unit/dh_ruby_test.rb"
Run options:

# Running tests:

.............................................

Finished tests in 4.800831s, 9.3734 tests/s, 12.2895 assertions/s.

45 tests, 59 assertions, 0 failures, 0 errors, 0 skips
[94/593]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb/gem2deb-0.5.1$ cd ..
[95/594]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb$ mv gem2deb-0.5.1 gem2deb-0.5.1+1
[96/595]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb$ cd gem2deb-0.5.1+1/
/home/mh/packages/gem2deb/gem2deb-0.5.1+1
[97/596]mh at salida[debian_chroot sid_build64]:~/packages/gem2deb/gem2deb-0.5.1+1$
 /usr/bin/ruby1.9.1 -I"lib:test" -I"/usr/lib/ruby/vendor_ruby" "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/unit/dh_make_ruby_test.rb" "test/unit/dh_ruby_test.rb"
Run options:

# Running tests:

EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE

Finished tests in 2.184468s, 20.6000 tests/s, 0.0000 assertions/s.

  1) Error:
test: DhMakeRuby should be able to specify a package name. (DhMakeRubyTest):
Errno::ENOENT: No such file or directory - debian/rules
    /home/mh/packages/gem2deb/gem2deb-0.5.1+1/lib/gem2deb/dh_make_ruby.rb:201:in `create_debian_boilerplates'
    /home/mh/packages/gem2deb/gem2deb-0.5.1+1/lib/gem2deb/dh_make_ruby.rb:141:in `block in build_in_directory'
    /home/mh/packages/gem2deb/gem2deb-0.5.1+1/lib/gem2deb/dh_make_ruby.rb:139:in `chdir'
    /home/mh/packages/gem2deb/gem2deb-0.5.1+1/lib/gem2deb/dh_make_ruby.rb:139:in `build_in_directory'
    /home/mh/packages/gem2deb/gem2deb-0.5.1+1/lib/gem2deb/dh_make_ruby.rb:133:in `block in build'
    /home/mh/packages/gem2deb/gem2deb-0.5.1+1/lib/gem2deb/dh_make_ruby.rb:129:in `chdir'
<snip>


Please consider fixing this issue.

Greetings
Marc