[DRE-maint] Bug#768850: ruby-activemodel, ruby-activesupport: needs Breaks for the packages it Replaces

[Andreas Beckmann]

Package: ruby-activemodel,ruby-activesupport
Version: 2:4.1.6-2
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts replaces-without-breaks

Hi,

during a test with piuparts and DOSE tools I noticed your package causes
removal of files that also belong to another package, leaving the other
package installed but crippled.
This is caused by using Replaces without corresponding Breaks.

This is a serious bug violating policy 7.6, see
http://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
and also see the footnote that describes this incorrect behavior
http://www.debian.org/doc/debian-policy/footnotes.html#f53

The ruby-activemodel package has the following relevant relationships:

  Conflicts: N/A
  Breaks:    N/A
  Replaces:  ruby-activemodel-3.2, ruby-activemodel-4.0

Since you intend to completely replace these packages, I suggest to add

  Breaks: ruby-activemodel-3.2, ruby-activemodel-4.0

(lintian may warn about a missing (<< $VER) clause - you can either ignore
that or make something up like (<< 2:4.1) - which should go to the Replaces
as well)

The same applies to the ruby-activesupport package which

  Replaces: ruby-activesupport-2.3, ruby-activesupport-3.2, ruby-activesupport-4.0

The other packages built from src:rails may have similar problems, I didn't
check in deep. They should be adjusted for consistency anyway.

But I could create test setups with crippled ruby-activemodel-3.2 and
ruby-activemodel-3.2 after installation and removal of the above two packages.
This may be an issue on wheezy -> jessie upgrades.


cheers,

Andreas