[DRE-maint] Bug#820065: gitlab: please adapt the postinst output for Debian

[Johannes Schauer]

Package: gitlab
Version: 8.5.8+dfsg-3
Severity: wishlist

Hi,

when upgrading gitlab, the user might be presented with stanzas like
this:


     [...]
     Check GitLab API access: FAILED. code: 502
     gitlab-shell self-check failed
       Try fixing it:
       Make sure GitLab is running;
       Check the gitlab-shell configuration file:
       sudo -u gitlab -H editor /usr/share/gitlab-shell/config.yml
       Please fix the error above and rerun the checks.
     [...]
     Checking Sidekiq ...
     
     Running? ... no
       Try fixing it:
       sudo -u gitlab -H RAILS_ENV=production bin/background_jobs start
       For more information see:
       doc/install/installation.md in section "Install Init Script"
       see log/sidekiq.log for possible errors
       Please fix the error above and rerun the checks.
     [...]
     All migrations up? ... no
       Try fixing it:
       sudo -u gitlab -H bundle exec rake db:migrate RAILS_ENV=production
       Please fix the error above and rerun the checks.
     [...]


As a user, I'd expect that after installing the "gitlab" package, I can
follow the above instructions without problems. Unfortunately, this is
not the case, because:

 - the gitlab package does not Depends, Recommends or Suggests sudo or
   an editor
 - executing bin/background_jobs does not seem to work on a Debian
   system
 - as described in README.Debian, the "sudo -u gitlab -H bundle exec
   rake" line will not work on Debian gitlab

I see the following ways to fix this:

 - suggest sudo and editor
 - adapt the messages such that they give advice which can be executed
   on a Debian gitlab installation
 - add more sections to README.Debian like "if gitlab tells you to run
   A, run B instead"

Thanks!

cheers, josch