[DRE-maint] updating ruby-ssh/capistrano

[micah anderson]

Hi all,

I need a newer ruby-sshkit, so I updated the package in the repository
(but did not upload). However, when building the rdepends, I noticed
that capistrano failed some tests. Since ruby-ssh and capistrano are so
closely connected to each other, I didn't want to upload a new
ruby-sshkit if capistrano fails, so I look at updating capistrano to the
latest version to see if it would fix the failures.

The newer capistrano requires a new library (airbrussh), so I got that
packaged and pushed that to the repository. I then insert that as an
extra-package to sbuild when I run the build script... all of that goes
fine...except when the capistrano tests run, they fail generically on
some issue (a different one from the ruby-ssh one from above).

It seems like there is a single fix that would resolve all these tests,
but I dont understand tests enough to debug what is going on.


I pushed everything to the repository, it would be great if someone with
moar skills with tests could help with this final piece:


 1) Capistrano::Doctor::GemsDoctor prints the SSHKit version
     Failure/Error:
       expect { doc.call }.to\
         output(/sshkit\s+#{Regexp.quote(SSHKit::VERSION)}/).to_stdout

       expected block to output /sshkit\s+1\.9\.0/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/sshkit\s+1\.9\.0/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:27:in `block (2 levels) in <module:Doctor>'

  2) Capistrano::Doctor::GemsDoctor prints the Airbrussh version
     Failure/Error:
       expect { doc.call }.to\
         output(/airbrussh\s+#{Regexp.quote(Airbrussh::VERSION)}/).to_stdout

       expected block to output /airbrussh\s+1\.1\.1/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/airbrussh\s+1\.1\.1/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:32:in `block (2 levels) in <module:Doctor>'

  3) Capistrano::Doctor::GemsDoctor prints the net-ssh version
     Failure/Error:
       expect { doc.call }.to\
         output(/net-ssh\s+#{Regexp.quote(Net::SSH::Version::STRING)}/).to_stdout

       expected block to output /net-ssh\s+3\.2\.0/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/net-ssh\s+3\.2\.0/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:37:in `block (2 levels) in <module:Doctor>'

  4) Capistrano::Doctor::GemsDoctor prints the Rake version
     Failure/Error:
       expect { doc.call }.to\
         output(/rake\s+#{Regexp.quote(Rake::VERSION)}/).to_stdout

       expected block to output /rake\s+10\.5\.0/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/rake\s+10\.5\.0/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:22:in `block (2 levels) in <module:Doctor>'

  5) Capistrano::Doctor::GemsDoctor warns that new version is available
     Failure/Error: expect { doc.call }.to output(/\(update available\)/).to_stdout

       expected block to output /\(update available\)/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/\(update available\)/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:43:in `block (2 levels) in <module:Doctor>'

  6) Capistrano::Doctor::GemsDoctor prints using 4-space indentation
     Failure/Error: expect { doc.call }.to output(/^ {4}/).to_stdout

       expected block to output /^ {4}/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/^ {4}/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:13:in `block (2 levels) in <module:Doctor>'

  7) Capistrano::Doctor::GemsDoctor prints the Capistrano version
     Failure/Error:
       expect { doc.call }.to\
         output(/capistrano\s+#{Regexp.quote(Capistrano::VERSION)}/).to_stdout

       expected block to output /capistrano\s+3\.6\.1/ to stdout, but output "\nGems\n"
       Diff:
       @@ -1,2 +1,3 @@
       -/capistrano\s+3\.6\.1/
       +
       +Gems
     # ./spec/lib/capistrano/doctor/gems_doctor_spec.rb:17:in `block (2 levels) in <module:Doctor>'




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 962 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20161115/f33f138f/attachment.sig>