[DRE-maint] Bug#846180: gitlab not restarted after redis-server upgrade

[Jason Rhinelander]

Package: gitlab
Version: 8.13.6+dfsg1-2
Severity: normal

Dear Maintainer,

I just installed an upgraded version of redis-server (but not of gitlab 
itself), and after the upgrade gitlab was no longer running.  The 
following reproduces this easily for me:


$ for i in "" -mailroom -sidekiq -unicorn -workhorse; do
   s=gitlab$i; echo $s; sudo service $s status | grep Active; done

gitlab
    Active: active (exited) since Mon 2016-11-28 21:06:38 EST; 3s ago
gitlab-mailroom
    Active: active (running) since Mon 2016-11-28 21:06:26 EST; 15s ago
gitlab-sidekiq
    Active: active (running) since Mon 2016-11-28 21:06:38 EST; 3s ago
gitlab-unicorn
    Active: active (running) since Mon 2016-11-28 21:06:26 EST; 15s ago
gitlab-workhorse
    Active: active (running) since Mon 2016-11-28 21:06:26 EST; 15s ago



$ sudo apt-get install redis-server --reinstall

Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 0 not 
upgraded.
Need to get 0 B/407 kB of archives.
After this operation, 0 B of additional disk space will be used.
(Reading database ... 253802 files and directories currently installed.)
Preparing to unpack .../redis-server_3%3a3.2.5-2_amd64.deb ...
Unpacking redis-server (3:3.2.5-2) over (3:3.2.5-2) ...
Processing triggers for systemd (232-6) ...
Processing triggers for man-db (2.7.5-2) ...
Setting up redis-server (3:3.2.5-2) ...



$ for i in "" -mailroom -sidekiq -unicorn -workhorse; do
   s=gitlab$i; echo $s; sudo service $s status | grep Active; done

gitlab
    Active: inactive (dead) since Mon 2016-11-28 21:06:49 EST; 13s ago
gitlab-mailroom
    Active: inactive (dead) since Mon 2016-11-28 21:06:50 EST; 13s ago
gitlab-sidekiq
    Active: inactive (dead) since Mon 2016-11-28 21:06:52 EST; 10s ago
gitlab-unicorn
    Active: inactive (dead) since Mon 2016-11-28 21:06:50 EST; 12s ago
gitlab-workhorse
    Active: inactive (dead) since Mon 2016-11-28 21:06:49 EST; 13s ago



I have no idea whether this is something wrong in the gitlab service 
files, something wrong in redis-server, or something elsewhere (e.g. in 
debhelper's scripts for restarting on upgrade).


Jason Rhinelander