[DRE-maint] Bug#836536: ruby-concurrent: FTBFS too much often (failed examples)

[Santiago Vila]

Package: src:ruby-concurrent
Version: 1.0.0-1
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
   dh_testdir -i -O--buildsystem=ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
	dh_ruby --test
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby

[... snipped ...]


     RuntimeError:
     # ./spec/concurrent/agent_spec.rb:954:in `block (4 levels) in <module:Concurrent>'

  5) Concurrent::Agent waiting with #await_for! raises an error if restarted with :clear_actions true
     # the timing is nearly impossible
     Failure/Error:
                 pending('the timing is nearly impossible'); fail
                 subject = Agent.new(0, error_mode: :fail)
       
                 subject.send_via(executor){ sleep(0.1) }
                 subject.send_via(executor){ raise StandardError }
                 subject.send_via(executor){ nil }
       
                 t = Thread.new{ subject.restart(42, clear_actions: true) }
       
                 expect {

     RuntimeError:
     # ./spec/concurrent/agent_spec.rb:1007:in `block (4 levels) in <module:Concurrent>'

  6) Concurrent::Synchronization Concurrent::Synchronization::LockableObject signaling for now pending, tested pretty well by Event
     # Not yet implemented
     # ./spec/concurrent/synchronization_spec.rb:172

  7) Concurrent::LazyRegister 
     # Not yet implemented
     # ./spec/concurrent/lazy_register_spec.rb:4

Failures:

  1) Concurrent::Agent waiting the await job does not trigger the error mode
     Failure/Error: expect(subject.value).to eq 11

       expected: 11
            got: 10

       (compared using ==)
     # ./spec/concurrent/agent_spec.rb:808:in `block (4 levels) in <module:Concurrent>'

Finished in 1 minute 21.56 seconds (files took 0.626 seconds to load)
1255 examples, 1 failure, 7 pending

Failed examples:

rspec ./spec/concurrent/agent_spec.rb:803 # Concurrent::Agent waiting the await job does not trigger the error mode

Randomized with seed 28093

/usr/bin/ruby2.3 /usr/bin/rspec --pattern ./spec/concurrent/\*_spec.rb --format documentation failed
ERROR: Test "ruby2.3" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-concurrent returned exit code 1
debian/rules:6: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

The failure does not seem related to using "dpkg-buildpackage -A".

It does not always fail, but it fails often enough to allow me to
attach 5 different failed build logs to this report.

The builds were made on KVM virtual machines using sbuild and an
up-to-date stretch chroot (plus diffutils 3.5 from unstable, but this
is not the reason it fails), with memory ranging from 768 MB (plus 1 GB
of swap) to 3 GB (plus 4 GB of swap).

BTW: I think the "Randomized with seed xxx" above is a bad idea.
Maintainers often ask bug reporters for "a way to reproduce the error".
But if the build is based on random variables, this becomes an
impossible task. Please consider modifying the build system so that
those random things are always the same.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-concurrent_1.0.0-1_amd64-20160903T022630Z.gz
Type: application/gzip
Size: 20379 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20160903/38d6a9a1/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-concurrent_1.0.0-1_amd64-20160903T180334Z.gz
Type: application/gzip
Size: 20514 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20160903/38d6a9a1/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-concurrent_1.0.0-1_amd64-20160903T180617Z.gz
Type: application/gzip
Size: 20610 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20160903/38d6a9a1/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-concurrent_1.0.0-1_amd64-20160903T180806Z.gz
Type: application/gzip
Size: 20660 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20160903/38d6a9a1/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-concurrent_1.0.0-1_amd64-20160903T181046Z.gz
Type: application/gzip
Size: 20742 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20160903/38d6a9a1/attachment-0009.bin>