[DRE-maint] Bug#837088: ruby-devise: 4.1.1-3 cause Circular dependency fail positives

[Justin F. Hallett]

Package: ruby-devise
Version: 4.1.1-3
Severity: important

Dear Maintainer,

took me 2 days to find this as gitlab woudl not start since the update to -3.  Today I rolled back to -2 and everything works without issue.  Here is the error from gitlab when -3 is installed.

I had previously incorrectly filed this bug with gitlab, it should have been here, instead of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836870

I, [2016-09-07T10:37:22.324249 #5548]  INFO -- : Refreshing Gem list
/usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:492:in `load_missing_constant': Circular dependency detected while autoloading constant ConfirmationsController (RuntimeError)
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:184:in `const_missing'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:526:in `load_missing_constant'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:184:in `const_missing'
    from /usr/share/gitlab/app/controllers/confirmations_controller.rb:1:in `<top (required)>'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:274:in `require'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:274:in `block in require'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:240:in `load_dependency'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:274:in `require'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:360:in `require_or_load'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:317:in `depend_on'
    from /usr/lib/ruby/vendor_ruby/active_support/dependencies.rb:233:in `require_dependency'
    from /usr/lib/ruby/vendor_ruby/rails/engine.rb:472:in `block (2 levels) in eager_load!'
    from /usr/lib/ruby/vendor_ruby/rails/engine.rb:471:in `each'
    from /usr/lib/ruby/vendor_ruby/rails/engine.rb:471:in `block in eager_load!'
    from /usr/lib/ruby/vendor_ruby/rails/engine.rb:469:in `each'
    from /usr/lib/ruby/vendor_ruby/rails/engine.rb:469:in `eager_load!'
    from /usr/lib/ruby/vendor_ruby/rails/engine.rb:346:in `eager_load!'
    from /usr/lib/ruby/vendor_ruby/rails/application/finisher.rb:56:in `each'
    from /usr/lib/ruby/vendor_ruby/rails/application/finisher.rb:56:in `block in <module:Finisher>'
    from /usr/lib/ruby/vendor_ruby/rails/initializable.rb:30:in `instance_exec'
    from /usr/lib/ruby/vendor_ruby/rails/initializable.rb:30:in `run'
    from /usr/lib/ruby/vendor_ruby/rails/initializable.rb:55:in `block in run_initializers'
    from /usr/lib/ruby/2.3.0/tsort.rb:228:in `block in tsort_each'
    from /usr/lib/ruby/2.3.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
    from /usr/lib/ruby/2.3.0/tsort.rb:431:in `each_strongly_connected_component_from'
    from /usr/lib/ruby/2.3.0/tsort.rb:349:in `block in each_strongly_connected_component'
    from /usr/lib/ruby/2.3.0/tsort.rb:347:in `each'
    from /usr/lib/ruby/2.3.0/tsort.rb:347:in `call'
    from /usr/lib/ruby/2.3.0/tsort.rb:347:in `each_strongly_connected_component'
    from /usr/lib/ruby/2.3.0/tsort.rb:226:in `tsort_each'
    from /usr/lib/ruby/2.3.0/tsort.rb:205:in `tsort_each'
    from /usr/lib/ruby/vendor_ruby/rails/initializable.rb:54:in `run_initializers'
    from /usr/lib/ruby/vendor_ruby/rails/application.rb:352:in `initialize!'
    from /usr/share/gitlab/config/environment.rb:5:in `<top (required)>'
    from config.ru:19:in `require'
    from config.ru:19:in `block in <main>'
    from /usr/lib/ruby/vendor_ruby/rack/builder.rb:55:in `instance_eval'
    from /usr/lib/ruby/vendor_ruby/rack/builder.rb:55:in `initialize'
    from config.ru:1:in `new'
    from config.ru:1:in `<main>'
    from /usr/lib/ruby/vendor_ruby/unicorn.rb:46:in `eval'
    from /usr/lib/ruby/vendor_ruby/unicorn.rb:46:in `block in builder'
    from /usr/bin/unicorn_rails:139:in `block in rails_builder'
    from /usr/lib/ruby/vendor_ruby/unicorn/http_server.rb:752:in `build_app!'
    from /usr/lib/ruby/vendor_ruby/unicorn/http_server.rb:129:in `start'
    from /usr/bin/unicorn_rails:209:in `<main>'

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.6.0-1-amd64 (SMP w/24 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages ruby-devise depends on:
ii  ruby              1:2.3.0+4
ii  ruby-bcrypt       3.1.11-1
ii  ruby-orm-adapter  0.5.0-2
ii  ruby-railties     2:4.2.7.1-1
ii  ruby-responders   2.3.0-1
ii  ruby-thor         0.19.1-2
ii  ruby-thread-safe  0.3.5-3
ii  ruby-warden       1.2.3-2

ruby-devise recommends no packages.

ruby-devise suggests no packages.

-- no debconf information