[DRE-maint] Bug#861459: ruby-protected-attributes: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:ruby-protected-attributes
Version: 1.1.3-2
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
   dh_testdir -i -O--buildsystem=ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
	dh_ruby --test
   create-stamp debian/debhelper-build-stamp
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby

[... snipped ...]

    /usr/lib/ruby/vendor_ruby/active_record/connection_adapters/abstract/database_statements.rb:213:in `block in transaction'
    /usr/lib/ruby/vendor_ruby/active_record/connection_adapters/abstract/transaction.rb:184:in `within_new_transaction'
    /usr/lib/ruby/vendor_ruby/active_record/connection_adapters/abstract/database_statements.rb:213:in `transaction'
    /usr/lib/ruby/vendor_ruby/active_record/transactions.rb:220:in `transaction'
    /usr/lib/ruby/vendor_ruby/active_record/transactions.rb:348:in `with_transaction_returning_status'
    /usr/lib/ruby/vendor_ruby/active_record/transactions.rb:286:in `block in save'
    /usr/lib/ruby/vendor_ruby/active_record/transactions.rb:301:in `rollback_active_record_state!'
    /usr/lib/ruby/vendor_ruby/active_record/transactions.rb:285:in `save'
    /<<PKGBUILDDIR>>/lib/active_record/mass_assignment_security/associations.rb:145:in `create_record'
    /<<PKGBUILDDIR>>/lib/active_record/mass_assignment_security/associations.rb:128:in `create'
    /usr/lib/ruby/vendor_ruby/active_record/associations/builder/singular_association.rb:22:in `create_best_friend'
    /<<PKGBUILDDIR>>/test/attribute_sanitization_test.rb:649:in `test_has_one_create_without_protection'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:107:in `block (3 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:204:in `capture_exceptions'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:104:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:255:in `time_it'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:103:in `block in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:348:in `on_signal'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:275:in `with_info_handler'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:102:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:799:in `run_one_method'
    /usr/lib/ruby/vendor_ruby/minitest.rb:322:in `run_one_method'
    /usr/lib/ruby/vendor_ruby/minitest.rb:310:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:309:in `each'
    /usr/lib/ruby/vendor_ruby/minitest.rb:309:in `block in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:348:in `on_signal'
    /usr/lib/ruby/vendor_ruby/minitest.rb:335:in `with_info_handler'
    /usr/lib/ruby/vendor_ruby/minitest.rb:308:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:158:in `block in __run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:158:in `map'
    /usr/lib/ruby/vendor_ruby/minitest.rb:158:in `__run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:135:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:62:in `block in autorun'

203 runs, 728 assertions, 0 failures, 1 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -I"test"  "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/accessible_params_wrapper_test.rb" "test/attribute_sanitization_test.rb" "test/mass_assignment_security/black_list_test.rb" "test/mass_assignment_security/permission_set_test.rb" "test/mass_assignment_security/sanitizer_test.rb" "test/mass_assignment_security/strong_parameters_fallback_test.rb" "test/mass_assignment_security/white_list_test.rb" "test/mass_assignment_security_test.rb" "test/test_helper.rb" -v]

Tasks: TOP => default
(See full trace by running task with --trace)
ERROR: Test "ruby2.3" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-protected-attributes returned exit code 1
debian/rules:6: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/ruby-protected-attributes/

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Thanks.