[DRE-maint] Bug#854714: trocla: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:trocla
Version: 0.2.3-1
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
dh: Compatibility levels before 9 are deprecated (level 7 in use)
   dh_testdir -i -O--buildsystem=ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
dh_auto_configure: Compatibility levels before 9 are deprecated (level 7 in use)
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
dh_auto_build: Compatibility levels before 9 are deprecated (level 7 in use)
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
dh_auto_test: Compatibility levels before 9 are deprecated (level 7 in use)

[... snipped ...]

Rewriting shebang line of /<<PKGBUILDDIR>>/debian/trocla/usr/bin/trocla

┌──────────────────────────────────────────────────────────────────────────────┐
│ Install Rubygems integration metadata                                        │
└──────────────────────────────────────────────────────────────────────────────┘

generating gemspec at /<<PKGBUILDDIR>>/debian/trocla/usr/share/rubygems-integration/all/specifications/trocla-0.2.3.gemspec
/usr/bin/ruby2.3 /usr/bin/gem2deb-test-runner

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.3 from debian/ruby-tests.rake                            │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=/<<PKGBUILDDIR>>/debian/trocla/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/trocla/usr/share/rubygems-integration/all:/var/lib/gems/2.3.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.3.0:/usr/share/rubygems-integration/2.3.0:/usr/share/rubygems-integration/all ruby2.3 -S rake -f debian/ruby-tests.rake
/usr/bin/ruby2.3 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb
...............................................................................................................................................................F........

Failures:

  1) Trocla password with profiles is possible to combine profiles but first profile wins 3
     Failure/Error: expect(pwd).to match(/[+%\/@=\?_.,:]+/)

       expected "ozzZVnFUJBf6s4zwnEk6iMLRJd1YXEOP" to match /[+%\/@=\?_.,:]+/
       Diff:
       @@ -1,2 +1,2 @@
       -/[+%\/@=\?_.,:]+/
       +"ozzZVnFUJBf6s4zwnEk6iMLRJd1YXEOP"
     # ./spec/trocla_spec.rb:73:in `block (4 levels) in <top (required)>'

Finished in 2 minutes 3.1 seconds (files took 0.13712 seconds to load)
168 examples, 1 failure

Failed examples:

rspec ./spec/trocla_spec.rb:69 # Trocla password with profiles is possible to combine profiles but first profile wins 3

/usr/bin/ruby2.3 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb failed
ERROR: Test "ruby2.3" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/trocla returned exit code 1
debian/rules:21: recipe for target 'override_dh_auto_install' failed
make[1]: *** [override_dh_auto_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:18: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/trocla/

The test suite apparently creates a random string and then expect it
to match certain regexp.

This reminds me of this other bug:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838828

where the algorithm to create the random string was flawed (there,
the intention was to create a string that never matched a certain regexp,
but the procedure to build such string did not ensure such thing).

If this case is similar (i.e. wrongly designed test) my only
recommendation is to just disable the randomly failing test.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Thanks.