[DRE-maint] Bug#851317: ruby-sidekiq-cron: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:ruby-sidekiq-cron
Version: 0.4.2-6
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
   dh_testdir -i -O--buildsystem=ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
	dh_ruby --test
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby
   dh_testroot -i -O--buildsystem=ruby

[... snipped ...]

          `-._        _.-'                                           
              `-.__.-'                                               

32743:M 10 Jan 19:00:11.643 # WARNING: The TCP backlog setting of 511 cannot be enforced because /proc/sys/net/core/somaxconn is set to the lower value of 128.
32743:M 10 Jan 19:00:11.643 # Server started, Redis version 3.2.6
32743:M 10 Jan 19:00:11.643 # WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
32743:M 10 Jan 19:00:11.643 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled.
32743:M 10 Jan 19:00:11.643 * The server is now ready to accept connections on port 6379
/usr/bin/ruby2.3 -I"lib:test"  "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/unit/job_test.rb" "test/unit/web_extesion_test.rb" 
Run options: --seed 34567

# Running:

..........F....................................................................

Finished in 0.122728s, 643.7006 runs/s, 1262.9569 assertions/s.

  1) Failure:
Cron Job::cron test#test_0002_return previous hour [/<<PKGBUILDDIR>>/test/unit/job_test.rb:221]:
--- expected
+++ actual
@@ -1,2 +1,2 @@
 # encoding: UTF-8
-"2017-01-10-18-01-00"
+"2017-01-10-19-01-00"


79 runs, 155 assertions, 1 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -I"lib:test"  "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/unit/job_test.rb" "test/unit/web_extesion_test.rb" ]

Tasks: TOP => test
(See full trace by running task with --trace)
+ cleanup
+ kill -9 32743
rake aborted!
Command failed with status (1): [./debian/start-redis-server.sh ruby2.3 -S ...]
/<<PKGBUILDDIR>>/debian/ruby-tests.rake:5:in `block in <top (required)>'
Tasks: TOP => default
(See full trace by running task with --trace)
ERROR: Test "ruby2.3" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-sidekiq-cron returned exit code 1
debian/rules:6: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/ruby-sidekiq-cron/

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Thanks.