[DRE-maint] Bug#852707: schleuder: FTBFS : refresh_keys test suite fails

[Daniel Kahn Gillmor]

Package: schleuder
Version: 3.0.1-1
Severity: normal

Hi there--

I've just tried to build schleduer 3.0.1-1 from git commit
6216f558d82f5a1038139ec0371916585bd08cfc

and the test suite shows two failures:


-------------
Failures:

  1) cli #refresh_keys reports errors from refreshing keys
     Failure/Error: expect(Mail::TestMailer.deliveries.length).to eq 1

       expected: 1
            got: 0

       (compared using ==)
     # ./spec/schleuder/integration/cli_spec.rb:117:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:28:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:27:in `block (2 levels) in <top (required)>'

  2) cli #refresh_keys updates one key from the keyserver
     Failure/Error: expect(Mail::TestMailer.deliveries.length).to eq 1

       expected: 1
            got: 0

       (compared using ==)
     # ./spec/schleuder/integration/cli_spec.rb:102:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:28:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:27:in `block (2 levels) in <top (required)>'

Finished in 1 minute 33.09 seconds (files took 1.06 seconds to load)
157 examples, 2 failures

Failed examples:

rspec ./spec/schleuder/integration/cli_spec.rb:109 # cli #refresh_keys reports errors from refreshing keys
rspec ./spec/schleuder/integration/cli_spec.rb:92 # cli #refresh_keys updates one key from the keyserver

Randomized with seed 48039
-------------

I think that looks like 3.0.1-1 was uploaded to debian with both
source and binary packages [0], so the buildd's don't have a chance to
build it.  If you do future uploads as source-only builds
("dpkg-buildpackage -S" or "gbp buildpackage -S") then that gives the
buildds a chance to build cleanly and run the test suites.

I note that having a test suite contact the network (as the two
failing tests appear to want to do) is also probably not a great idea.
It means that the test suite will fail on a build daemon that doesn't
have network access, and also that it may intermittently fail based on
whether the remote network service is available.

Thanks for your work packaging schleuder for debian!

       --dkg

[0] see the .deb in https://packages.qa.debian.org/s/schleuder/news/20170126T152017Z.html

-- System Information:
Debian Release: 9.0
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (200, 'unstable-debug'), (200, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)