[DRE-maint] Bug#863960: gitlab: unowned files after purge (policy 6.8, 10.8)

[Andreas Beckmann]

Package: gitlab
Version: 8.13.11+dfsg1-7
Severity: important
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8 (or 10.8):

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

>From the attached log (scroll to the bottom...):

43m12.9s ERROR: FAIL: Package purging left files on system:
  /etc/gitlab-shell/	 not owned
  /etc/rc0.d/K01gitlab -> ../init.d/gitlab	 not owned
  /etc/rc1.d/K01gitlab -> ../init.d/gitlab	 not owned
  /etc/rc2.d/S01gitlab -> ../init.d/gitlab	 not owned
  /etc/rc3.d/S01gitlab -> ../init.d/gitlab	 not owned
  /etc/rc4.d/S01gitlab -> ../init.d/gitlab	 not owned
  /etc/rc5.d/S01gitlab -> ../init.d/gitlab	 not owned
  /etc/rc6.d/K01gitlab -> ../init.d/gitlab	 not owned
  /etc/systemd/system/gitlab.service -> /dev/null	 not owned
  /etc/systemd/system/gitlab.target -> /dev/null	 not owned
  /etc/systemd/system/gitlab.target.wants/	 not owned
  /etc/systemd/system/gitlab.target.wants/gitlab.service -> /lib/systemd/system/gitlab.service	 not owned
  /etc/systemd/system/multi-user.target.wants/gitlab.target -> /lib/systemd/system/gitlab.target	 not owned
  /usr/share/gitlab-shell/.gitlab_shell_secret -> /var/lib/gitlab/.gitlab_shell_secret	 not owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.service.dsh-also	 not owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.target.dsh-also	 not owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.target.wants/	 not owned
  /var/lib/systemd/deb-systemd-helper-enabled/gitlab.target.wants/gitlab.service	 not owned
  /var/lib/systemd/deb-systemd-helper-enabled/multi-user.target.wants/gitlab.target	 not owned
  /var/lib/systemd/deb-systemd-helper-masked/	 not owned
  /var/lib/systemd/deb-systemd-helper-masked/gitlab.service	 not owned
  /var/lib/systemd/deb-systemd-helper-masked/gitlab.target	 not owned
  /var/log/gitlab-shell/	 not owned
  /var/log/gitlab-shell/gitlab-shell.log	 not owned

43m12.9s INFO: Warning: Package purging left files on system:
  /etc/systemd/system/multi-user.target.wants/	 not owned
  /usr/share/gitlab-shell/	 owned by: gitlab-shell
  /var/lib/systemd/deb-systemd-helper-enabled/multi-user.target.wants/	 not owned


Most of these should be fixable by correctly using the initscripts
packaging helpers ... leaving us with

  /usr/share/gitlab-shell/.gitlab_shell_secret
  /var/log/gitlab-shell/gitlab-shell.log

which should probably be managed by the gitlab-shell package.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gitlab_8.13.11+dfsg1-7.log.gz
Type: application/gzip
Size: 184922 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20170602/adb2e950/attachment-0001.bin>