[DRE-maint] Bug#856606: gitlab: fails to upgrade from 'stretch': nginx example configuration file not found

[Pirate Praveen]

On ഞായര്‍ 05 മാര്‍ച്ച് 2017 01:00 രാവിലെ, Andreas Beckmann wrote:
> I don't think that is written explicitly in the policy, but there seems
> to be general understanding that you must be able upgrade from one
> package version to the next package version within a suite (unstable,
> testing, stable) as well as between suites (oldstable->stable,
> stable->testing, testing->unstable). (This may not be true for packages
> in experimental, but once the package gets uploaded to unstable ... you
> want to be able to upgrade from the previous version in unstable to the
> current one).
> What is usually not supported are upgrades that skip stable releases
> (e.g. upgrading directly from old-oldstable to stable without upgrading
> from old-oldstable to oldstable first).
> 
> If you disagree, please take this to the tech-ctte.

I disagree and taking it to tech-ctte.

>>> What else would you want to do with a gitlab installation in testing if
>>> upgrading does not work?
>> Did you update /etc/gitlab/gitlab-debian.conf?
> 
> I didn't touch anything, I'm just doing automated upgrade tests with
> piuparts, so all config files are at their defaults.
> 
>> This happened because a
>> configuration file has changed. How am I supposed to make changes in
>> configuration files then?
> 
> Use ucf? But you already use this.
> Or what do you mean with "making changes in configuration files"?
> 
> Having briefly looked at the postinst script, it appears to me that all
> the nginx_* variables are not set at all ...

nginx_* variables are set in gitlab-debian.conf. Since this version of
gitlab makes a change in those variables postinst should be looking at
new locations, but ucf seems to be not installing the new version of
config file.

These variables are set in line 45 of postinst. I tried moving ucf
registration code before this line, but the result is same.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20170309/d8a99047/attachment.sig>