[DRE-maint] Bug#876317: ruby-moneta: build-depends on default-mysql-server but relies on mariadb interfaces

[Steve Langasek]

Package: ruby-moneta
Version: 1.0.0-1
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch

Dear maintainer,

Recent versions of ruby-moneta have been failing to build in Ubuntu because
you have switched the build-depency of the package from mysql-server to
default-mysql-server and at the same time have begun using mariadb-specific
interfaces:

RUBYLIB=/<<PKGBUILDDIR>>/debian/ruby-moneta/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/ruby-moneta/usr/share/rubygems-integration/all:/var/lib/gems/2.3.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.3.0:/usr/share/rubygems-integration/2.3.0:/usr/share/rubygems-integration/all ruby2.3 debian/ruby-tests.rb
mysql_install_db: [ERROR] unknown option '--rpm'
2017-09-09 09:53:02 [ERROR]   Unrecognized options
Unable to start the test MySQL server.
ERROR: Test "ruby2.3" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-moneta returned exit code 1
debian/rules:15: recipe for target 'binary' failed

  https://launchpad.net/ubuntu/+source/ruby-moneta/1.0.0-1/+build/13271049

This failure happens because Ubuntu's default-mysql-server is mysql, not
mariadb, and mysql does not implement this '--rpm' option.

default-mysql-server is only a reasonable build dependency if you don't care
about which implementation you have.  Since ruby-moneta depends on
interfaces that are only available from the mysql-server package, you should
build-depend on mysql-server directly.

With the attached patch, ruby-moneta builds successfully in Ubuntu.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru ruby-moneta-1.0.0/debian/control ruby-moneta-1.0.0/debian/control
--- ruby-moneta-1.0.0/debian/control	2017-08-19 07:56:07.000000000 -0700
+++ ruby-moneta-1.0.0/debian/control	2017-09-20 15:03:36.000000000 -0700
@@ -6,7 +6,7 @@
 Build-Depends: debhelper (>= 10~),
                gem2deb
 Build-Depends-Indep: lsof,
-                     default-mysql-server,
+                     mariadb-server,
                      netcat,
                      ruby-activesupport (>= 2:3.2.11~),
                      ruby-fog,