[DRE-maint] Bug#882308: http-parser 2.7 breaks ruby-em-http-request's tests

[Jérémy Lal]

Control: reassign -1 ruby-em-http-request
I took the liberty to reassign it to it. Feel free to reassign to
whichever you see it would be better assigned.

Please try this patch on ruby-em-http-request.

--- a/lib/em-http/http_connection.rb
+++ b/lib/em-http/http_connection.rb
@@ -131,7 +131,7 @@
       end

       @p.on_message_complete = proc do
-        if !client.continue?
+        if client and !client.continue?
           c = @clients.shift
           c.state = :finished
           c.on_request_complete




Also i tried this but if fails:

--- a/lib/em-http/http_connection.rb
+++ b/lib/em-http/http_connection.rb
@@ -131,7 +131,7 @@
       end

       @p.on_message_complete = proc do
-        if !client.continue?
+        if !client or !client.continue?
           c = @clients.shift
           c.state = :finished
           c.on_request_complete

"c" is Nil here: the change with http-parser 2.7 makes
"on_message_complete" called in a case when it wasn't before.

Bug or feature ? nodejs is using http-parser and has a thorough test suite,
so i suppose we're on the safe side fixing this package (but my experience
tells me i'm 80% wrong when i suppose things like that).

Jérémy




2018-04-04 0:16 GMT+02:00 Jérémy Lal <jerry at eda.sarl>:

>
>
> 2018-04-03 23:22 GMT+02:00 Christoph Biedl <debian.axhn at manchmal.in-ulm.de
> >:
>
>> Jérémy Lal wrote...
>>
>> > Control: reassign -1 ruby-http-parser.rb
>>
>> Thanks for taking care of that one. However ...
>>
>> > it seems ruby-em-http-request uses a fork of http_parser.rb that has not
>> > been updated for a while. However, upstream seems to have fixed some
>> > issues with more recents http-parser developments:
>> >
>> > https://github.com/tmm1/http_parser.rb/commit/7ef407e3524775
>> 0e369746dec4ed4ed6c2265f73
>> >
>> > So it'd rather be ruby-http-parser.rb debian package that needs a patch
>> here.
>>
>> The *ruby-http-parser.rb* package has been fixed in #881627 (yes, that
>> was me). The failing package however is *ruby-em-http-request*, and
>> while you state it's is fork of the first, I cannot quite see a lot of
>> common code.
>>
>> Are you sure the assignment to ruby-http-parser.rb is correct?
>>
>>     Christoph, still trying to understand why the tests fail
>>
>
> I'm looking at it more thoroughly. Sorry for the thoughtless decision to
> move the bug,
> i'll put it back to where it belongs if necesssary.
>
> Jérémy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20180404/31d2ac7d/attachment.html>