[DRE-maint] Bug#906656: ruby-openid-connect: FTBFS in buster/sid (failing tests)

[Santiago Vila]

Package: src:ruby-openid-connect
Version: 0.12.0-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
	dh_ruby --test
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby
   dh_testroot -i -O--buildsystem=ruby
   dh_prep -i -O--buildsystem=ruby

[... snipped ...]

     # ./lib/openid_connect/response_object/id_token.rb:51:in `left_half_hash_of'
     # ./lib/openid_connect/response_object/id_token.rb:39:in `to_jwt'
     # ./spec/openid_connect/response_object/id_token_spec.rb:155:in `block (5 levels) in <top (required)>'

  2) OpenIDConnect::ResponseObject::IdToken#to_jwt when access_token is given when access_token is a String it should behave like id_token_with_at_hash should include at_hash
     Failure/Error: UrlSafeBase64.encode64 digest[0, hash_length / (2 * 8)]

     NameError:
       uninitialized constant OpenIDConnect::ResponseObject::IdToken::UrlSafeBase64
     Shared Example Group: :id_token_with_at_hash called from ./spec/openid_connect/response_object/id_token_spec.rb:172
     # ./lib/openid_connect/response_object/id_token.rb:51:in `left_half_hash_of'
     # ./lib/openid_connect/response_object/id_token.rb:39:in `to_jwt'
     # ./spec/openid_connect/response_object/id_token_spec.rb:155:in `block (5 levels) in <top (required)>'

  3) OpenIDConnect::ResponseObject::IdToken#to_jwt when code is given should include at_hash
     Failure/Error: UrlSafeBase64.encode64 digest[0, hash_length / (2 * 8)]

     NameError:
       uninitialized constant OpenIDConnect::ResponseObject::IdToken::UrlSafeBase64
     # ./lib/openid_connect/response_object/id_token.rb:51:in `left_half_hash_of'
     # ./lib/openid_connect/response_object/id_token.rb:42:in `to_jwt'
     # ./spec/openid_connect/response_object/id_token_spec.rb:179:in `block (4 levels) in <top (required)>'

  4) OpenIDConnect::ResponseObject::IdToken#to_jwt when both access_token and code are given should include at_hash
     Failure/Error: UrlSafeBase64.encode64 digest[0, hash_length / (2 * 8)]

     NameError:
       uninitialized constant OpenIDConnect::ResponseObject::IdToken::UrlSafeBase64
     # ./lib/openid_connect/response_object/id_token.rb:51:in `left_half_hash_of'
     # ./lib/openid_connect/response_object/id_token.rb:39:in `to_jwt'
     # ./spec/openid_connect/response_object/id_token_spec.rb:195:in `block (4 levels) in <top (required)>'

Finished in 4.47 seconds (files took 0.93138 seconds to load)
217 examples, 4 failures, 2 pending

Failed examples:

rspec './spec/openid_connect/response_object/id_token_spec.rb[1:3:3:1:1:1]' # OpenIDConnect::ResponseObject::IdToken#to_jwt when access_token is given when access_token is a Rack::OAuth2::AccessToken it should behave like id_token_with_at_hash should include at_hash
rspec './spec/openid_connect/response_object/id_token_spec.rb[1:3:3:2:1:1]' # OpenIDConnect::ResponseObject::IdToken#to_jwt when access_token is given when access_token is a String it should behave like id_token_with_at_hash should include at_hash
rspec ./spec/openid_connect/response_object/id_token_spec.rb:178 # OpenIDConnect::ResponseObject::IdToken#to_jwt when code is given should include at_hash
rspec ./spec/openid_connect/response_object/id_token_spec.rb:194 # OpenIDConnect::ResponseObject::IdToken#to_jwt when both access_token and code are given should include at_hash

/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation failed
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/ruby-openid-connect returned exit code 1
make: *** [debian/rules:7: binary-indep] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -A" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ruby-openid-connect.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.