[DRE-maint] Bug#907149: roodi: FTBFS in buster/sid (invalid use of incomplete type 'class QButtonGroup')

[Santiago Vila]

Package: src:roodi
Version: 5.0.0-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
dh: Compatibility levels before 9 are deprecated (level 7 in use)
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
dh_auto_configure: Compatibility levels before 9 are deprecated (level 7 in use)
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
dh_auto_build: Compatibility levels before 9 are deprecated (level 7 in use)
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
dh_auto_test: Compatibility levels before 9 are deprecated (level 7 in use)
	dh_ruby --test

[... snipped ...]

Checked 87 files
Found 0 errors.
.
Running Roodi checks

Checked 87 files
Found 0 errors.
.....

Failures:

  1) Roodi::Checks::EmptyRescueBodyCheck should reject a rescue block that only contains a comment
     Failure/Error: errors[0].to_s.should match(/dummy-file.rb:[5] - Rescue block should not be empty./)

       expected "dummy-file.rb:3 - Rescue block should not be empty." to match /dummy-file.rb:[5] - Rescue block should not be empty./
       Diff:
       @@ -1,2 +1,2 @@
       -/dummy-file.rb:[5] - Rescue block should not be empty./
       +"dummy-file.rb:3 - Rescue block should not be empty."
     # ./spec/roodi/checks/empty_rescue_body_check_spec.rb:209:in `block (2 levels) in <top (required)>'

Deprecation Warnings:

Using `should_not` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /<<PKGBUILDDIR>>/spec/roodi/checks/abc_metric_method_check_spec.rb:12:in `verify_content_score'.

Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /<<PKGBUILDDIR>>/spec/roodi/core/runner_spec.rb:58:in `block (3 levels) in <top (required)>'.


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

2 deprecation warnings total

Finished in 0.92636 seconds (files took 0.34406 seconds to load)
115 examples, 1 failure

Failed examples:

rspec ./spec/roodi/checks/empty_rescue_body_check_spec.rb:197 # Roodi::Checks::EmptyRescueBodyCheck should reject a rescue block that only contains a comment

/usr/bin/ruby2.5 /usr/bin/rspec spec/roodi/checks/abc_metric_method_check_spec.rb spec/roodi/checks/assignment_in_conditional_check_spec.rb spec/roodi/checks/case_missing_else_check_spec.rb spec/roodi/checks/class_line_count_check_spec.rb spec/roodi/checks/class_name_check_spec.rb spec/roodi/checks/class_variable_check_spec.rb spec/roodi/checks/control_coupling_check_spec.rb spec/roodi/checks/core_method_override_check_spec.rb spec/roodi/checks/cyclomatic_complexity_block_check_spec.rb spec/roodi/checks/cyclomatic_complexity_method_check_spec.rb spec/roodi/checks/empty_rescue_body_check_spec.rb spec/roodi/checks/for_loop_check_spec.rb spec/roodi/checks/method_line_count_check_spec.rb spec/roodi/checks/method_name_check_spec.rb spec/roodi/checks/module_line_count_check_spec.rb spec/roodi/checks/module_name_check_spec.rb spec/roodi/checks/npath_complexity_method_check_spec.rb spec/roodi/checks/parameter_number_check_spec.rb spec/roodi/core/runner_spec.rb spec/roodi_task_spec.rb failed
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/roodi returned exit code 1
make: *** [debian/rules:15: binary-indep] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -A" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/roodi.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.