[DRE-maint] Bug#907322: jekyll: Requires internet access to build

[Jeremy Bicha]

Source: jekyll
Version: 3.8.3+dfsg-2
Severity: serious
X-Debbugs-CC: praveen at debian.org

jekyll fails to build from source if the build environment does not
have Internet access.

This can be seen in Debian's reproducible builds and Ubuntu's builders.

I am filing this as serious because it is a violation of Debian Policy
§ 4.9 which says "no required targets may attempt network access".

By the way, there is a recently added patch,
0004_skip_test_autopkgtest.patch, that is not listed in
debian/patches/series. I enabled it in my local testing, but it didn't
fix the build failure.

Build logs
=======
https://launchpad.net/ubuntu/+source/jekyll/3.8.3+dfsg-2/+build/15298887

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/jekyll.html
(see test history and rbuild)

Build log excerpt
============

RUBYLIB=/build/1st/jekyll-3.8.3+dfsg/debian/jekyll/usr/lib/ruby/vendor_ruby:.
GEM_PATH=debian/jekyll/usr/share/rubygems-integration/all:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all
ruby2.5 -S rake -f debian/ruby-tests.rake
/usr/bin/ruby2.5 -w -I"lib:lib:test"
"/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb"
"test/test_ansi.rb" "test/test_cleaner.rb" "test/test_coffeescript.rb"
"test/test_collections.rb" "test/test_command.rb"
"test/test_commands_serve.rb" "test/test_commands_serve_servlet.rb"
"test/test_configuration.rb" "test/test_data_reader.rb"
"test/test_doctor_command.rb" "test/test_document.rb"
"test/test_drop.rb" "test/test_entry_filter.rb" "test/test_excerpt.rb"
"test/test_excerpt_drop.rb" "test/test_filters.rb"
"test/test_front_matter_defaults.rb" "test/test_generated_site.rb"
"test/test_kramdown.rb" "test/test_layout_reader.rb"
"test/test_liquid_extensions.rb" "test/test_liquid_renderer.rb"
"test/test_log_adapter.rb" "test/test_page.rb"
"test/test_page_without_a_file.rb" "test/test_path_sanitization.rb"
"test/test_rdiscount.rb" "test/test_redcarpet.rb"
"test/test_regenerator.rb" "test/test_related_posts.rb"
"test/test_sass.rb" "test/test_site_drop.rb"
"test/test_static_file.rb" "test/test_url.rb" "test/test_utils.rb"
# -------------------------------------------------------------
# SPECS AND TESTS ARE RUNNING WITH WARNINGS OFF.
# SEE: https://github.com/Shopify/liquid/issues/730
# SEE: https://github.com/jekyll/jekyll/issues/4719
# -------------------------------------------------------------

# Running tests with run options --seed 6667:

........................................................................................................................................................................F........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished tests in 298.388558s, 2.2018 tests/s, 3.6865 assertions/s.


Failure:
Minitest::Result#test_: Utils::Internet.connected? should return true
if there's internet.
[/build/1st/jekyll-3.8.3+dfsg/test/test_utils.rb:420]
Minitest::Assertion: Expected false to be truthy.

657 tests, 1100 assertions, 1 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to
/build/1st/jekyll-3.8.3+dfsg/coverage. 3257 / 3815 LOC (85.37%)
covered.
rake aborted!
Command failed with status (1): [ruby -w -I"lib:lib:test"
"/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb"
"test/test_ansi.rb" "test/test_cleaner.rb" "test/test_coffeescript.rb"
"test/test_collections.rb" "test/test_command.rb"
"test/test_commands_serve.rb" "test/test_commands_serve_servlet.rb"
"test/test_configuration.rb" "test/test_data_reader.rb"
"test/test_doctor_command.rb" "test/test_document.rb"
"test/test_drop.rb" "test/test_entry_filter.rb" "test/test_excerpt.rb"
"test/test_excerpt_drop.rb" "test/test_filters.rb"
"test/test_front_matter_defaults.rb" "test/test_generated_site.rb"
"test/test_kramdown.rb" "test/test_layout_reader.rb"
"test/test_liquid_extensions.rb" "test/test_liquid_renderer.rb"
"test/test_log_adapter.rb" "test/test_page.rb"
"test/test_page_without_a_file.rb" "test/test_path_sanitization.rb"
"test/test_rdiscount.rb" "test/test_redcarpet.rb"
"test/test_regenerator.rb" "test/test_related_posts.rb"
"test/test_sass.rb" "test/test_site_drop.rb"
"test/test_static_file.rb" "test/test_url.rb" "test/test_utils.rb" ]

Tasks: TOP => default => test
(See full trace by running task with --trace)
ERROR: Test "ruby2.5" failed. Exiting.


Thanks,
Jeremy Bicha