[DRE-maint] Bug#873440: ruby-grpc FTBFS: cc1: error: -Wformat-security ignored without -Wformat

[Steve Langasek]

Package: ruby-grpc
Version: 1.3.2+debian-3
Followup-For: Bug #873440
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Hi Pirate,

Here's a patch to fix this build failure, which has been uploaded to Ubuntu.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru ruby-grpc-1.3.2+debian/debian/patches/no-cflags-override.patch ruby-grpc-1.3.2+debian/debian/patches/no-cflags-override.patch
--- ruby-grpc-1.3.2+debian/debian/patches/no-cflags-override.patch	1969-12-31 16:00:00.000000000 -0800
+++ ruby-grpc-1.3.2+debian/debian/patches/no-cflags-override.patch	2018-02-03 20:20:51.000000000 -0800
@@ -0,0 +1,19 @@
+Description: Don't set -Wno-format which conflicts with default hardening flags
+ ruby-grpc sets -Wno-format in cflags, but by default Debian sets -Wformat
+ -Werror=format-security.  Passing -Wno-format breaks setting
+ -Werror=format-security, which should be kept for security reasons.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+Bug-Debian: https://bugs.debian.org/873400
+
+Index: ruby-grpc-1.3.2+debian/src/ruby/ext/grpc/extconf.rb
+===================================================================
+--- ruby-grpc-1.3.2+debian.orig/src/ruby/ext/grpc/extconf.rb
++++ ruby-grpc-1.3.2+debian/src/ruby/ext/grpc/extconf.rb
+@@ -106,7 +106,6 @@
+ $CFLAGS << ' -Wall '
+ $CFLAGS << ' -Wextra '
+ $CFLAGS << ' -pedantic '
+-$CFLAGS << ' -Wno-format '
+ 
+ output = File.join('grpc', 'grpc_c')
+ puts 'Generating Makefile for ' + output
diff -Nru ruby-grpc-1.3.2+debian/debian/patches/series ruby-grpc-1.3.2+debian/debian/patches/series
--- ruby-grpc-1.3.2+debian/debian/patches/series	2017-08-04 11:36:52.000000000 -0700
+++ ruby-grpc-1.3.2+debian/debian/patches/series	2018-02-03 20:18:41.000000000 -0800
@@ -3,3 +3,4 @@
 no-make-in-extconf.patch
 use-system-grpc.patch
 fix-protoc-path.patch
+no-cflags-override.patch