[DRE-maint] Bug#860198: ruby-rack-proxy: accesses the internet during build

[Sergio Durigan Junior]

Control: tags -1 + patch

On Wednesday, April 12 2017, Chris Lamb wrote:

> Dear Maintainer,
>
> Whilst ruby-rack-proxy builds successfully on unstable/amd64, according to
> Debian Policy 4.9 packages may not attempt network access during
> a build.
>
>    00:00:00.000000 IP d682a225d2b3.36041 > OpenWrt.lan.domain: 28604+ A? www.trix.pl. (29)
>    00:00:00.000044 IP d682a225d2b3.36041 > OpenWrt.lan.domain: 34431+ AAAA? www.trix.pl. (29)
>    00:00:00.092699 IP OpenWrt.lan.domain > d682a225d2b3.36041: 28604 2/0/0 CNAME the-trix.herokuapp.com., A 79.125.24.174 (81)
>    00:00:00.191672 IP OpenWrt.lan.domain > d682a225d2b3.36041: 34431 1/0/0 CNAME the-trix.herokuapp.com. (65)
>    00:00:00.191856 IP d682a225d2b3.57820 > ec2-79-125-24-174.eu-west-1.compute.amazonaws.com.http: Flags [S], seq 1530273777, win 29200, options [mss 1460,sackOK,TS val 260183652 ecr 0,nop,wscale 7], length 0
>    00:00:00.213026 IP ec2-79-125-24-174.eu-west-1.compute.amazonaws.com.http > d682a225d2b3.57820: Flags [S.], seq 3395934634, ack 1530273778, win 26847, options [mss 1400,sackOK,TS val 558302644 ecr 260183652,nop,wscale 8], length 0
>    00:00:00.213062 IP d682a225d2b3.57820 > ec2-79-125-24-174.eu-west-1.compute.amazonaws.com.http: Flags [.], ack 1, win 229, options [nop,nop,TS val 260183657 ecr 558302644], length 0
>    00:00:00.213380 IP d682a225d2b3.57820 > ec2-79-125-24-174.eu-west-1.compute.amazonaws.com.http: Flags [P.], seq 1:127, ack 1, win 229, options [nop,nop,TS val 260183657 ecr 558302644], length 126: HTTP: GET / HTTP/1.1
>    00:00:00.237399 IP ec2-79-125-24-174.eu-west-1.compute.amazonaws.com.http > d682a225d2b3.57820: Flags [.], ack 127, win 105, options [nop,nop,TS val 558302650 ecr 260183657], length 0
>    00:00:00.253453 IP ec2-79-125-24-174.eu-west-1.compute.amazonaws.com.http > d682a225d2b3.57820: Flags [.], seq 1:1389, ack 127, win 105, options [nop,nop,TS val 558302653 ecr 260183657], length 1388: HTTP: HTTP/1.1 200 OK 
>
>   [..]
>
> The full build log (including tcpdump output) is attached.

Hi,

I decided to give this bug a try, and came up with the patch attached.

The problem here is that some testcases are trying to access the
internet, which, as has been mentioned already, is not allowed under the
Debian Policy.  Unfortunately, this is one of those cases when it's not
really possible to disable network access for the tests, so the "best"
fix is to prevent the tests from running.  The patch does that.

This makes the package buildable on my cowbuilder chroot (without
internet) again.

Cheers,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-rack-proxy-tests.patch
Type: text/x-diff
Size: 1262 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20180211/be86f102/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ruby-extras-maintainers/attachments/20180211/be86f102/attachment.sig>