[DRE-maint] Bug#888117: ruby-beautify: FTBFS on ruby2.5: tests fail: .. got: "EXPR_BEG
Chris West (Faux)
debian at fau.xxx
Tue Jan 23 14:51:10 UTC 2018
Source: ruby-beautify
Version: 0.97.4-3
Severity: important
User: debian-ruby at lists.debian.org
Usertags: ruby2.5
Dear Maintainer,
This package fails to build against ruby2.5. Soon, there will
be a transition to ruby2.5, and this package will FTBFS in sid.
There may be some details on the wiki about common problems:
https://wiki.debian.org/Teams/Ruby/Ruby25Transition
Build log:
┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-tests.rake │
└──────────────────────────────────────────────────────────────────────────────┘
RUBYLIB=/build/ruby-beautify-0.97.4/debian/ruby-beautify/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/ruby-beautify/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 -S rake -f debian/ruby-tests.rake
/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation
Ruby Beautify
will work
will do multiple files
will update files (overwrite) in place
will honor --spaces
will honor the ident_count prefix
will use a .ruby-beautify config file
Ruby Beautify Library
#pretty_string
will indent by tab ( by default ) (FAILED - 1)
will indent by space (FAILED - 2)
will honor indent count (FAILED - 3)
Usage Scenarios
will test: mutli_level (FAILED - 4)
will test: case (FAILED - 5)
will test: from_control (FAILED - 6)
will test: or_equals (FAILED - 7)
will test: lambda_literal (FAILED - 8)
will test: pre_indented (FAILED - 9)
will test: multiline_strings (FAILED - 10)
will test: monolithic_example (FAILED - 11)
Failures:
1) Ruby Beautify Library #pretty_string will indent by tab ( by default )
Failure/Error: expect(RubyBeautify.pretty_string(@ugly_string)).to eq @pretty_string
expected: "# Test for already indented blocks\nclass There2 < There\n\tdef m1()\n\t\tputs \"m1\"\n\tend\n\tdef m2()\n\t\tputs \"m2\"\n\tend\n\tdef m3()\n\t\tputs \"m3\"\n\tend\nend\n"
got: "EXPR_BEGEXPR_BEGEXPR_CLASSEXPR_CLASSEXPR_ARGEXPR_ARGEXPR_BEGEXPR_BEGEXPR_CMDARGEXPR_BEG\tEXPR_BEGEXP...XPR_CMDARGEXPR_CMDARGEXPR_END|EXPR_ENDARGEXPR_BEG\tEXPR_BEGEXPR_ENDEXPR_BEGEXPR_BEGEXPR_ENDEXPR_BEG"
(compared using ==)
Diff:
@@ -1,13 +1,2 @@
-# Test for already indented blocks
-class There2 < There
- def m1()
- puts "m1"
- end
- def m2()
- puts "m2"
- end
- def m3()
- puts "m3"
- end
-end
+EXPR_BEGEXPR_BEGEXPR_CLASSEXPR_CLASSEXPR_ARGEXPR_ARGEXPR_BEGEXPR_BEGEXPR_CMDARGEXPR_BEG EXPR_BEGEXPR_FNAMEEXPR_FNAMEEXPR_ENDFNEXPR_BEG|EXPR_LABELEXPR_ENDFNEXPR_BEG EXPR_BEGEXPR_CMDARGEXPR_CMDARGEXPR_CMDARGEXPR_CMDARGEXPR_END|EXPR_ENDARGEXPR_BEG EXPR_BEGEXPR_ENDEXPR_BEG EXPR_FNAMEEXPR_FNAMEEXPR_ENDFNEXPR_BEG|EXPR_LABELEXPR_ENDFNEXPR_BEG EXPR_BEGEXPR_CMDARGEXPR_CMDARGEXPR_CMDARGEXPR_CMDARGEXPR_END|EXPR_ENDARGEXPR_BEG EXPR_BEGEXPR_ENDEXPR_BEG EXPR_BEGEXPR_FNAMEEXPR_FNAMEEXPR_ENDFNEXPR_BEG|EXPR_LABELEXPR_ENDFNEXPR_BEG EXPR_CMDARGEXPR_CMDARGEXPR_CMDARGEXPR_CMDARGEXPR_END|EXPR_ENDARGEXPR_BEG EXPR_BEGEXPR_ENDEXPR_BEGEXPR_BEGEXPR_ENDEXPR_BEG
# ./spec/lib/ruby-beautify_spec.rb:15:in `block (3 levels) in <top (required)>'
2) Ruby Beautify Library #pretty_string will indent by space
Failure/Error: expect(RubyBeautify.pretty_string(@ugly_string, indent_token:' ')).to eq @pretty_string_space
expected: "# Test for already indented blocks\nclass There2 < There\n def m1()\n puts \"m1\"\n end\n def m2()\n puts \"m2\"\n end\n def m3()\n puts \"m3\"\n end\nend\n"
got: "EXPR_BEGEXPR_BEGEXPR_CLASSEXPR_CLASSEXPR_ARGEXPR_ARGEXPR_BEGEXPR_BEGEXPR_CMDARGEXPR_BEG EXPR_BEGEXPR...EXPR_CMDARGEXPR_CMDARGEXPR_END|EXPR_ENDARGEXPR_BEG EXPR_BEGEXPR_ENDEXPR_BEGEXPR_BEGEXPR_ENDEXPR_BEG"
...
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /build/ruby-beautify-0.97.4/debian/ruby-beautify returned exit code 1
debian/rules:15: recipe for target 'override_dh_auto_install' failed
Full build log:
https://rbuild.fau.xxx/2018-01-23/ruby-beautify.log
Cheers,
Chris.
More information about the Pkg-ruby-extras-maintainers
mailing list