[DRE-maint] Bug#888125: ruby-email-reply-parser: test relies on timing / speed

[Chris West (Faux)]

Source: ruby-email-reply-parser
Version: 0.5.8-2
Severity: wishlist

Dear Maintainer,

This package occasionally fails to build on build servers, as it
has tests which fail dependent on system load.

Please make it not do that.

(Note that this was run on an experimental ruby2.5 builder, which is not
currently anything like sid. Hopefully it doesn't change the outcome.)


Build log:

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-test-files.yaml                       │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=/build/ruby-email-reply-parser-0.5.8/debian/ruby-email-reply-parser/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/ruby-email-reply-parser/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 -ryaml -e YAML.load_file\(\"debian/ruby-test-files.yaml\"\).each\ \{\ \|f\|\ require\ f\ \}
Loaded suite -e
Started
..............F
===============================================================================
Failure:
  Took too long, upgrade to re2 gem.
  <false> is not true.
test_pathological_emails(EmailReplyParserTest)
/build/ruby-email-reply-parser-0.5.8/test/email_reply_parser_test.rb:195:in `test_pathological_emails'
     192:   def test_pathological_emails
     193:     t0 = Time.now
     194:     reply = email("pathological")
  => 195:     assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem."
     196:   end
     197: 
     198:   def test_doesnt_remove_signature_delimiter_in_mid_line
===============================================================================
........

Finished in 8.758398299 seconds.
------
23 tests, 68 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
95.6522% passed
------
2.63 tests/s, 7.76 assertions/s


Cheers,
Chris.