[DRE-maint] Bug#888129: ruby-json-spec: FTBFS on ruby2.5: Fixnum/Integer

[Chris West (Faux)]

Source: ruby-json-spec
Version: 1.1.2-1
Severity: important
User: debian-ruby at lists.debian.org
Usertags: ruby2.5

Dear Maintainer,

This package fails to build against ruby2.5. Soon, there will
be a transition to ruby2.5, and this package will FTBFS in sid.

There may be some details on the wiki about common problems:
https://wiki.debian.org/Teams/Ruby/Ruby25Transition

Build log excerpt:

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-tests.rake                            │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=/build/ruby-json-spec-1.1.2/debian/ruby-json-spec/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/ruby-json-spec/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 -S rake -f debian/ruby-tests.rake
/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb
................................................WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<RuntimeError: Expected equivalent JSON not provided>. Instead consider providing a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`. Called from /build/ruby-json-spec-1.1.2/spec/json_spec/matchers/be_json_eql_spec.rb:102:in `block (2 levels) in <top (required)>'.
............................F................WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<RuntimeError: Expected included JSON not provided>. Instead consider providing a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`. Called from /build/ruby-json-spec-1.1.2/spec/json_spec/matchers/include_json_spec.rb:75:in `block (2 levels) in <top (required)>'.
..................

Failures:

  1) JsonSpec::Matchers::HaveJsonType provides a failure message for negation
     Failure/Error: matcher.failure_message_when_negated.should   == "Expected JSON value type to not be Numeric, got Fixnum"

       expected: "Expected JSON value type to not be Numeric, got Fixnum"
            got: "Expected JSON value type to not be Numeric, got Integer" (using ==)
     # ./spec/json_spec/matchers/have_json_type_spec.rb:59:in `block (2 levels) in <top (required)>'

Finished in 0.09429 seconds (files took 0.20874 seconds to load)
111 examples, 1 failure

Failed examples:

rspec ./spec/json_spec/matchers/have_json_type_spec.rb:56 # JsonSpec::Matchers::HaveJsonType provides a failure message for negation

/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb failed
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /build/ruby-json-spec-1.1.2/debian/ruby-json-spec returned exit code 1
debian/rules:15: recipe for target 'binary' failed
make: *** [binary] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Full build log:
https://rbuild.fau.xxx/2018-01-23/ruby-json-spec.log

Please fix it!

Cheers,
Chris.