[DRE-maint] Bug#888163: ruby-net-ssh: FTBFS on ruby2.5: OpenSSL::Digest::DSS1

[Chris West (Faux)]

Source: ruby-net-ssh
Version: 1:4.2.0-2
Severity: important
User: debian-ruby at lists.debian.org
Usertags: ruby2.5

Dear Maintainer,

This package fails to build against ruby2.5. Soon, there will
be a transition to ruby2.5, and this package will FTBFS in sid.

There may be some details on the wiki about common problems:
https://wiki.debian.org/Teams/Ruby/Ruby25Transition

Build log excerpt:


Finished in 2.351047s, 628.2308 runs/s, 2105.0196 assertions/s.

  1) Error:
Authentication::TestAgent#test_add_dsa_cert_identity:
NameError: uninitialized constant OpenSSL::Digest::DSS1
    /build/ruby-net-ssh-4.2.0/lib/net/ssh/transport/openssl.rb:117:in `ssh_do_sign'
    /build/ruby-net-ssh-4.2.0/lib/net/ssh/authentication/certificate.rb:80:in `sign!'
    /build/ruby-net-ssh-4.2.0/test/authentication/test_agent.rb:401:in `make_cert'
    /build/ruby-net-ssh-4.2.0/test/authentication/test_agent.rb:258:in `test_add_dsa_cert_identity'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:107:in `block (3 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:204:in `capture_exceptions'


...

  2) Error:
Authentication::TestED25519#test_no_pwd_key:
RuntimeError: No ED25519 set NET_SSH_NO_RBNACL to ignore this test
    /build/ruby-net-ssh-4.2.0/test/authentication/test_ed25519.rb:11:in `setup'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:105:in `block (3 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:204:in `capture_exceptions'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:104:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:255:in `time_it'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:103:in `block in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:350:in `on_signal'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:275:in `with_info_handler'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:102:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:839:in `run_one_method'
..

  3) Error:
Authentication::TestED25519#test_pwd_key:
RuntimeError: No ED25519 set NET_SSH_NO_RBNACL to ignore this test
    /build/ruby-net-ssh-4.2.0/test/authentication/test_ed25519.rb:11:in `setup'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:105:in `block (3 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:204:in `capture_exceptions'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:104:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:255:in `time_it'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:103:in `block in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:350:in `on_signal'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:275:in `with_info_handler'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:102:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:839:in `run_one_method'
    /usr/lib/ruby/vendor_ruby/minitest.rb:324:in `run_one_method'
..


1477 runs, 4949 assertions, 0 failures, 3 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -w  "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/test_all.rb" "test/test_buffer.rb" "test/test_buffered_io.rb" "test/test_config.rb" "test/test_key_factory.rb" "test/test_known_hosts.rb" "test/test_proxy_jump.rb" -v]

Tasks: TOP => default
(See full trace by running task with --trace)
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /build/ruby-net-ssh-4.2.0/debian/ruby-net-ssh returned exit code 1
debian/rules:6: recipe for target 'binary' failed
make: *** [binary] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Full build log:
https://rbuild.fau.xxx/2018-01-23/ruby-net-ssh.log

Please fix it!

Cheers,
Chris.