[DRE-maint] Bug#888173: ruby-sawyer: FTBFS on ruby2.5: can't dump anonymous class

[Chris West (Faux)]

Source: ruby-sawyer
Version: 0.8.1-2
Severity: important
User: debian-ruby at lists.debian.org
Usertags: ruby2.5

Dear Maintainer,

This package fails to build against ruby2.5. Soon, there will
be a transition to ruby2.5, and this package will FTBFS in sid.

There may be some details on the wiki about common problems:
https://wiki.debian.org/Teams/Ruby/Ruby25Transition

Build log excerpt:


48 runs, 193 assertions, 0 failures, 0 errors, 0 skips
/usr/bin/ruby2.5 /usr/bin/gem2deb-test-runner

┌──────────────────────────────────────────────────────────────────────────────┐
│ Checking Rubygems dependency resolution on ruby2.5                           │
└──────────────────────────────────────────────────────────────────────────────┘

GEM_PATH=debian/ruby-sawyer/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 -e gem\ \"sawyer\"

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-tests.rb                              │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=/build/ruby-sawyer-0.8.1/debian/ruby-sawyer/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/ruby-sawyer/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 debian/ruby-tests.rb
Run options: --seed 2029

# Running:

....................E..........................E

Finished in 0.805228s, 59.6105 runs/s, 239.6838 assertions/s.

  1) Error:
Sawyer::ResourceTest#test_handle_yaml_dump:
TypeError: can't dump anonymous class: #<Class:#<Sawyer::Resource:0x000055c2d11cb238>>
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:343:in `visit_Class'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:136:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:546:in `block in dump_ivars'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:544:in `each'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:544:in `dump_ivars'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:163:in `visit_Object'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:136:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/yaml_tree.rb:118:in `push'
    /usr/lib/ruby/2.5.0/psych.rb:441:in `dump'
    /build/ruby-sawyer-0.8.1/test/resource_test.rb:172:in `test_handle_yaml_dump'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:107:in `block (3 levels) in run'

  2) Error:
Sawyer::AgentTest#test_handle_yaml_dump_and_load:
NoMethodError: undefined method `[]' for nil:NilClass
    /usr/lib/ruby/vendor_ruby/faraday/utils.rb:48:in `[]='
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:362:in `block in revive_hash'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `each'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `each_slice'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `revive_hash'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:271:in `block in visit_Psych_Nodes_Mapping'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:268:in `each'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:268:in `each_slice'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:268:in `visit_Psych_Nodes_Mapping'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:16:in `visit'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:6:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:32:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:338:in `block in revive_hash'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `each'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `each_slice'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `revive_hash'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:374:in `revive'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:208:in `visit_Psych_Nodes_Mapping'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:16:in `visit'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:6:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:32:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:338:in `block in revive_hash'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `each'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `each_slice'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:336:in `revive_hash'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:374:in `revive'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:208:in `visit_Psych_Nodes_Mapping'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:16:in `visit'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:6:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:32:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:311:in `visit_Psych_Nodes_Document'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:16:in `visit'
    /usr/lib/ruby/2.5.0/psych/visitors/visitor.rb:6:in `accept'
    /usr/lib/ruby/2.5.0/psych/visitors/to_ruby.rb:32:in `accept'
    /usr/lib/ruby/2.5.0/psych/nodes/node.rb:50:in `to_ruby'
    /usr/lib/ruby/2.5.0/psych.rb:264:in `load'
    /build/ruby-sawyer-0.8.1/test/agent_test.rb:174:in `test_handle_yaml_dump_and_load'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:107:in `block (3 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:204:in `capture_exceptions'

48 runs, 193 assertions, 0 failures, 2 errors, 0 skips
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /build/ruby-sawyer-0.8.1/debian/ruby-sawyer returned exit code 1
debian/rules:16: recipe for target 'binary' failed
make: *** [binary] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Full build log:
https://rbuild.fau.xxx/2018-01-23/ruby-sawyer.log

Please fix it!

Cheers,
Chris.