[DRE-maint] Bug#900066: gitlab: 500 error on merge request creation

[Simon Vetter]

Awesome, thank you for your prompt reply.

In the meantime and assuming the fix is in non-compiled code (i.e. 
ruby), would you mind sharing a patch here so I can apply it and get 
merge requests up and running again?

--
Simon Vetter
Embedded Software Engineer - EDF store & forecast
Phone: +33 7 83 40 26 11

On 05/26/2018 11:28 AM, Pirate Praveen wrote:
> Control: tags -1 pending
>
> On Friday 25 May 2018 09:03 PM, Simon Vetter wrote:
>> Processing by ProjectsController#autocomplete_sources as JSON
>>    Parameters: {"type"=>"MergeRequest", "namespace_id"=>"operations", 
>> "id"=>"ems"}
>> Completed 200 OK in 502ms (Views: 169.8ms | ActiveRecord: 53.2ms)
>> Started POST "/operations/ems/merge_requests" for [redacted ip 
>> address] at 2018-05-25 16:09:41 +0100
>> Processing by Projects::MergeRequestsController#create as HTML
>>    Parameters: {"utf8"=>"✓", "authenticity_token"=>"[redacted 
>> token]", "merge_request"=>{"title"=>"[redacted merge request title]", 
>> "description"=>"", "label_ids"=>[""], 
>> "force_remove_source_branch"=>"0", "lock_version"=>"0", 
>> "source_project_id"=>"1", "source_branch"=>"[redacted source git 
>> branch]", "target_project_id"=>"1", "target_branch"=>"master"}, 
>> "namespace_id"=>"operations", "project_id"=>"ems"}
>> Completed 500 Internal Server Error in 123ms (ActiveRecord: 13.2ms)
>>
>> NameError (undefined local variable or method `source_project' for 
>> #<MergeRequests::CreateService:0x0055dc04005920>
>> Did you mean?  @source_project):
>>    app/services/merge_requests/create_service.rb:6:in `execute'
>>    app/controllers/projects/merge_requests_controller.rb:254:in `create'
>>    lib/gitlab/request_profiler/middleware.rb:15:in `call'
>>    lib/gitlab/middleware/go.rb:16:in `call'
>
> Thanks for the report.
>
> This is now fixed in the stretch-updates branch and waiting for 
> approval from security team to upload the fixed version.
>