[DRE-maint] Bug#911869: ruby-sinatra-contrib FTBFS: tests fail during dh_ruby --install

[Helmut Grohne]

Source: ruby-sinatra-contrib
Version: 1.4.7-1
Severity: serious
Tags: ftbfs

ruby-sinatra-contrib fails to build from source. Apparently it runs
tests during dh_ruby --install and fails doing so:

| Failures:
| 
|   1) Sinatra::Cookies include? checks response cookies
|      Failure/Error: jar.should include(:foo)
| 
|        expected {"foo" => "bar"} to include :foo
|        Diff:
|        @@ -1,2 +1,2 @@
|        -[:foo]
|        +"foo" => "bar",
|      # ./spec/cookies_spec.rb:553:in `block (3 levels) in <top (required)>'
| 
| Deprecation Warnings:
| 
| Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /build/1st/ruby-sinatra-contrib-1.4.7/spec/capture_spec.rb:26:in `block (3 levels) in <top (required)>'.
| 
| `failure_message_for_should` is deprecated. Use `failure_message` instead. Called from /build/1st/ruby-sinatra-contrib-1.4.7/spec/decompile_spec.rb:10:in `block in <top (required)>'.
| 
| 
| If you need more of the backtrace for any of these deprecations to
| identify where to make the necessary changes, you can configure
| `config.raise_errors_for_deprecations!`, and it will turn the
| deprecation warnings into errors, giving you the full backtrace.
| 
| 2 deprecation warnings total
| 
| Finished in 5.13 seconds (files took 1.41 seconds to load)
| 837 examples, 1 failure
| 
| Failed examples:
| 
| rspec ./spec/cookies_spec.rb:550 # Sinatra::Cookies include? checks response cookies
| 
| /usr/bin/ruby2.5 /usr/bin/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed
| ERROR: Test "ruby2.5" failed. Exiting.
| dh_auto_install: dh_ruby --install /build/1st/ruby-sinatra-contrib-1.4.7/debian/ruby-sinatra-contrib returned exit code 1
| make: *** [debian/rules:4: binary] Error 1
| dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Helmut