[DRE-maint] Bug#907996: capistrano: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:capistrano
Version: 3.10.0-1
Severity: serious
Tags: ftbfs

Dear maintainer:

This package fails to build from source approximately half of the time:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=ruby --with ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_autoreconf -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
	dh_ruby --test
   create-stamp debian/debhelper-build-stamp
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby

[... snipped ...]

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) Capistrano::Application provides a --trace option which enables SSHKit/NetSSH trace output
     # Not yet implemented
     # ./spec/lib/capistrano/application_spec.rb:4

  2) Capistrano::Application provides a --format option which enables the choice of output formatting
     # Not yet implemented
     # ./spec/lib/capistrano/application_spec.rb:6

Failures:

  1) Capistrano::DSL checking for presence variable exists, is not an array 
     Failure/Error:
       def any?(key)
         value = fetch(key)
         if value && value.respond_to?(:any?)
           value.any?
         else
           !fetch(key).nil?
         end

     ArgumentError:
       wrong number of arguments (given 0, expected 1)
     # ./lib/capistrano/configuration.rb:47:in `any?'
     # ./lib/capistrano/configuration.rb:50:in `any?'
     # ./spec/integration/dsl_spec.rb:386:in `block (3 levels) in <top (required)>'
     # ./spec/integration/dsl_spec.rb:405:in `block (4 levels) in <top (required)>'

Finished in 0.17433 seconds (files took 0.33778 seconds to load)
386 examples, 1 failure, 2 pending

Failed examples:

rspec ./spec/integration/dsl_spec.rb:405 # Capistrano::DSL checking for presence variable exists, is not an array 

Randomized with seed 58644

/usr/bin/ruby2.5 /usr/bin/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/capistrano returned exit code 1
make[1]: *** [debian/rules:7: override_dh_auto_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:4: binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The quoted build log above was made in buster in my autobuilder with
"dpkg-buildpackage -A" but it also fails here *most* of the time:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/capistrano.html

I also tried to build it 100 times on n1-standard-1 instances from GCE
(this time on sid) and it failed 52 times:

https://people.debian.org/~sanvila/build-logs/capistrano/

(Note: I've not read the build logs myself, the failures could be
different, I don't know).

If for any reason you could not reproduce this (after trying several times, since
it's random), please say so, I could provide a test machine if required.

Thanks.