[DRE-maint] Bug#854714: trocla: FTBFS randomly (failing tests)

[Santiago Vila]

tags 854714 + patch
thanks

Hi. I've noticed this is still happening in buster, and contrary to
what I suggested in the initial bug report, the number of CPUs have
absolutely nothing to do with this. To reproduce, just build the
package a lot of times. I've added some more build logs here:

https://people.debian.org/~sanvila/build-logs/trocla/

If a failing test does not mean that the package is buggy and does not
follow its own specs, then the failing test should be disabled. The
attached patch disables the failing test.

OTOH, if a failing test means the package is buggy but the package is
useful anyway, then there is no point in making the build unsuccessful
when the test fails. In this case it would be better to disable the
failing test as well.

[ There is a third option, that the failing test means the package is
  buggy enough not to be trusted. If this is the case, the logical thing
  would be not to release buster with this package ].

Suggested patch below.

Thanks.

--- a/spec/trocla_spec.rb
+++ b/spec/trocla_spec.rb
@@ -66,12 +66,6 @@ describe "Trocla" do
         expect(pwd.length).to eq(16)
         expect(pwd).not_to match(/[={}\[\]\?%\*()&!]+/)
       end
-      it 'is possible to combine profiles but first profile wins 3' do
-        pwd = @trocla.password('some_test','plain', 'profiles' => ['mysql','login'])
-        expect(pwd).not_to be_empty
-        expect(pwd.length).to eq(32)
-        expect(pwd).to match(/[+%\/@=\?_.,:]+/)
-      end
     end
   end