[DRE-maint] Bug#927122: ruby2.5: Rinda::TestRingFinger test_make_socket_ipv4_multicast Errno::ENETUNREACH: Network is unreachable

[Ritesh Raj Sarraf]

Package: ruby2.5
Version: 2.5.5-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)

The current ruby2.5 package in Buster/Unstable fails to build from
scratch. It fails in some of the tests that depend on network
availability.

The tests are already disabled in
debian/tests/excludes/any/TestRingFinger.rb
debian/tests/excludes/any/TestRingServer.rb

but are not effective.

With this patch, the same tests are disabled in test/excludes/ and they
are effective.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (990, 'testing'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages ruby2.5 depends on:
ii  libc6                 2.28-8
ii  libgmp10              2:6.1.2+dfsg-4
ii  libruby2.5            2.5.5-1
ii  rubygems-integration  1.11

Versions of packages ruby2.5 recommends:
ii  fonts-lato    2.0-2
ii  libjs-jquery  3.3.1~dfsg-1

ruby2.5 suggests no packages.

-- no debconf information
-------------- next part --------------
The tests are marked excluded in debian/tests/excludes/any/TestRing*.rb
But they still get executed which results in the build failure.

In salsa commit:
https://salsa.debian.org/ruby-team/ruby/commit/2943f7b15ac47c9110b5f8bb5a2346eadefdb83f
the tests were explicitly disabled in tests/excludes/ in the upstream sources,
which works and is exactly this patch does.

There is also an upstream bug report about these tests failing but without any
resolution so far.
https://bugs.ruby-lang.org/issues/13864
Index: ruby2.5-2.5.5/test/excludes/Rinda/TestRingFinger.rb
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ ruby2.5-2.5.5/test/excludes/Rinda/TestRingFinger.rb	2019-04-15 14:38:46.343954009 +0530
@@ -0,0 +1,3 @@
+reason = "Network access not allowed during build in Debian"
+exclude :test_make_socket_ipv4_multicast, reason
+exclude :test_make_socket_ipv4_multicast_hops, reason
Index: ruby2.5-2.5.5/test/excludes/Rinda/TestRingServer.rb
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ ruby2.5-2.5.5/test/excludes/Rinda/TestRingServer.rb	2019-04-15 14:38:46.343954009 +0530
@@ -0,0 +1,3 @@
+reason = "Network access not allowed during build in Debian"
+exclude :test_make_socket_ipv4_multicast, reason
+exclude :test_ring_server_ipv4_multicast, reason
Index: ruby2.5-2.5.5/test/excludes/TestRinda.rb
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ ruby2.5-2.5.5/test/excludes/TestRinda.rb	2019-04-15 14:38:46.343954009 +0530
@@ -0,0 +1,5 @@
+reason = "Network access not allowed during build in Debian"
+exclude :test_make_socket_ipv4_multicast, reason
+exclude :test_make_socket_ipv4_multicast_hops, reason
+exclude :test_make_socket_ipv4_multicast, reason
+exclude :test_ring_server_ipv4_multicast, reason